You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/31 16:33:32 UTC
[GitHub] [maven-surefire] Tibor17 commented on issue #267: [SUREFIRE-1741]
JUnit5: Detect failed containers
Tibor17 commented on issue #267: [SUREFIRE-1741] JUnit5: Detect failed containers
URL: https://github.com/apache/maven-surefire/pull/267#issuecomment-580807711
I am traveling right now, so i will check it in several hours.
Dňa pi 31. 1. 2020, 10:33 Albert Johnston <no...@github.com>
napísal(a):
> *@ajohnstonTE* commented on this pull request.
> ------------------------------
>
> In
> surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
> <https://github.com/apache/maven-surefire/pull/267#discussion_r373387825>:
>
> > @@ -185,6 +188,13 @@ private SimpleReportEntry createReportEntry( TestIdentifier testIdentifier,
> stw, elapsedTime, reason, systemProperties );
> }
>
> + private boolean isFailedContainer( TestIdentifier testIdentifier,
> + TestExecutionResult testExecutionResult )
> + {
> + return testIdentifier.isContainer() && testExecutionResult != null
>
> In any event, IT's added for the other issue. That should be everything.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/267?email_source=notifications&email_token=AAH7ER7C6Q74PN7SKRVV77LRAPV7FA5CNFSM4KLEEYEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTY3DMI#discussion_r373387825>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAH7ERY7I4UHOOT4QIVHVKDRAPV7FANCNFSM4KLEEYEA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services