You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/14 18:35:09 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29541: Remove section check from get-value command
potiuk opened a new pull request, #29541:
URL: https://github.com/apache/airflow/pull/29541
The section check is not really needed and harmful. There should be no problems if sections are missing from the configuration file.
Running this check might lead to a problem that if someone stripds down the config file to bare minimum and moves the crucial configuration to env variables the 'get-value' command might fail, even if the configuration is perfectly sound for Airflow.
Fixes: #29537
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29541: Remove section check from get-value command
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29541:
URL: https://github.com/apache/airflow/pull/29541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29541: Remove section check from get-value command
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29541:
URL: https://github.com/apache/airflow/pull/29541#issuecomment-1430261677
Ah - removed a bit too much :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29541: Remove section check from get-value command
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29541:
URL: https://github.com/apache/airflow/pull/29541#discussion_r1106272584
##########
airflow/cli/commands/config_command.py:
##########
@@ -38,10 +38,6 @@ def show_config(args):
def get_value(args):
- """Get one value from configuration."""
- if not conf.has_section(args.section):
- raise SystemExit(f"The section [{args.section}] is not found in config.")
-
if not conf.has_option(args.section, args.option):
Review Comment:
```suggestion
"""Get one value from configuration."""
if not conf.has_option(args.section, args.option):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org