You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by ok...@apache.org on 2017/01/24 22:23:42 UTC
tinkerpop git commit: found a minor optimization to DedupGlobalStep.
No need to check for existence in barrier Map if dedupSet is being used.
Repository: tinkerpop
Updated Branches:
refs/heads/TINKERPOP-1564 7dfd7cfc9 -> b87022bf5
found a minor optimization to DedupGlobalStep. No need to check for existence in barrier Map if dedupSet is being used.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/b87022bf
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/b87022bf
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/b87022bf
Branch: refs/heads/TINKERPOP-1564
Commit: b87022bf516e9a2b8de976dd367461e4a9d92f20
Parents: 7dfd7cf
Author: Marko A. Rodriguez <ok...@gmail.com>
Authored: Tue Jan 24 15:23:39 2017 -0700
Committer: Marko A. Rodriguez <ok...@gmail.com>
Committed: Tue Jan 24 15:23:39 2017 -0700
----------------------------------------------------------------------
.../gremlin/process/traversal/step/filter/DedupGlobalStep.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/b87022bf/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupGlobalStep.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupGlobalStep.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupGlobalStep.java
index c6c4a80..8ccccfd 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupGlobalStep.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupGlobalStep.java
@@ -186,7 +186,7 @@ public final class DedupGlobalStep<S> extends FilterStep<S> implements Traversal
} else {
object = TraversalUtil.applyNullable(traverser, this.dedupTraversal);
}
- if (this.duplicateSet.add(object) && !map.containsKey(object)) {
+ if (this.duplicateSet.add(object)) {
traverser.setBulk(1L);
// traverser.detach();
traverser.set(DetachedFactory.detach(traverser.get(), true)); // TODO: detect required detachment accordingly