You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2009/12/23 16:28:29 UTC
[jira] Created: (SLING-1254) Change from maven-bundle-plugin 1.4.3
to 2.0.1 causes launchpad.base.jar to have too much stuff in it
Change from maven-bundle-plugin 1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
-----------------------------------------------------------------------------------------------------
Key: SLING-1254
URL: https://issues.apache.org/jira/browse/SLING-1254
Project: Sling
Issue Type: Bug
Components: Launchpad
Reporter: Justin Edelson
After r892734, the launchpad base jar has more content in it than it should (850 files instead 269 files). Most significantly, the contents of org.apache.sling.launchpad.base.shared are included which causes this exception:
> org.osgi.framework.BundleException: sling.home property is missing, cannot start
This appears to be because of a change in behavior in the maven-bundle-plugin between 1.4.3 and 2.0.1.
The fix is to replace the last line in the Private-Package instruction with org.apache.sling.launchpad.base.* and add an Export-Package instruction.
HOWEVER, the manifest that results from this is slightly different than the one produced prior to r892734. Specifically, it no longer has a Private-Package header. I'm not really sure why this is, but it doesn't seem to be a problem.
diff --git a/launchpad/base/pom.xml b/launchpad/base/pom.xml
index 2c5364d..8180955 100644
--- a/launchpad/base/pom.xml
+++ b/launchpad/base/pom.xml
@@ -69,8 +69,9 @@
!org.apache.sling.launchpad.app.*,
!org.apache.sling.launchpad.base.shared.*,
!org.apache.sling.launchpad.webapp.*,
- *
+ org.apache.sling.launchpad.base.*
</Private-Package>
+ <Export-Package>!*</Export-Package>
<Import-Package>!*</Import-Package>
<DynamicImport-Package>*</DynamicImport-Package>
<Embed-Dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1254) Change from maven-bundle-plugin 1.4.3
to 2.0.1 causes launchpad.base.jar to have too much stuff in it
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-1254:
----------------------------------
Priority: Critical (was: Major)
updating priority...
> Change from maven-bundle-plugin 1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-1254
> URL: https://issues.apache.org/jira/browse/SLING-1254
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Justin Edelson
> Priority: Critical
>
> After r892734, the launchpad base jar has more content in it than it should (850 files instead 269 files). Most significantly, the contents of org.apache.sling.launchpad.base.shared are included which causes this exception:
> > org.osgi.framework.BundleException: sling.home property is missing, cannot start
> This appears to be because of a change in behavior in the maven-bundle-plugin between 1.4.3 and 2.0.1.
> The fix is to replace the last line in the Private-Package instruction with org.apache.sling.launchpad.base.* and add an Export-Package instruction.
> HOWEVER, the manifest that results from this is slightly different than the one produced prior to r892734. Specifically, it no longer has a Private-Package header. I'm not really sure why this is, but it doesn't seem to be a problem.
> diff --git a/launchpad/base/pom.xml b/launchpad/base/pom.xml
> index 2c5364d..8180955 100644
> --- a/launchpad/base/pom.xml
> +++ b/launchpad/base/pom.xml
> @@ -69,8 +69,9 @@
> !org.apache.sling.launchpad.app.*,
> !org.apache.sling.launchpad.base.shared.*,
> !org.apache.sling.launchpad.webapp.*,
> - *
> + org.apache.sling.launchpad.base.*
> </Private-Package>
> + <Export-Package>!*</Export-Package>
> <Import-Package>!*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <Embed-Dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1254) Change from maven-bundle-plugin
1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794165#action_12794165 ]
Felix Meschberger commented on SLING-1254:
------------------------------------------
Thanks a lot for tracing this problem down -- this may finally explain why we have build failures in some circumstances with the reactor.
> Change from maven-bundle-plugin 1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-1254
> URL: https://issues.apache.org/jira/browse/SLING-1254
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Priority: Critical
>
> After r892734, the launchpad base jar has more content in it than it should (850 files instead 269 files). Most significantly, the contents of org.apache.sling.launchpad.base.shared are included which causes this exception:
> > org.osgi.framework.BundleException: sling.home property is missing, cannot start
> This appears to be because of a change in behavior in the maven-bundle-plugin between 1.4.3 and 2.0.1.
> The fix is to replace the last line in the Private-Package instruction with org.apache.sling.launchpad.base.* and add an Export-Package instruction.
> HOWEVER, the manifest that results from this is slightly different than the one produced prior to r892734. Specifically, it no longer has a Private-Package header. I'm not really sure why this is, but it doesn't seem to be a problem.
> diff --git a/launchpad/base/pom.xml b/launchpad/base/pom.xml
> index 2c5364d..8180955 100644
> --- a/launchpad/base/pom.xml
> +++ b/launchpad/base/pom.xml
> @@ -69,8 +69,9 @@
> !org.apache.sling.launchpad.app.*,
> !org.apache.sling.launchpad.base.shared.*,
> !org.apache.sling.launchpad.webapp.*,
> - *
> + org.apache.sling.launchpad.base.*
> </Private-Package>
> + <Export-Package>!*</Export-Package>
> <Import-Package>!*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <Embed-Dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1254) Change from maven-bundle-plugin
1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794168#action_12794168 ]
Felix Meschberger commented on SLING-1254:
------------------------------------------
Applied the patch in Rev. 893602 (in addition I also removed the .app.* and .webapp.* lines because they are not needed at all.
The Private-Package header is a special header creted by the BND library and is ignored by the framework.
> Change from maven-bundle-plugin 1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-1254
> URL: https://issues.apache.org/jira/browse/SLING-1254
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Priority: Critical
>
> After r892734, the launchpad base jar has more content in it than it should (850 files instead 269 files). Most significantly, the contents of org.apache.sling.launchpad.base.shared are included which causes this exception:
> > org.osgi.framework.BundleException: sling.home property is missing, cannot start
> This appears to be because of a change in behavior in the maven-bundle-plugin between 1.4.3 and 2.0.1.
> The fix is to replace the last line in the Private-Package instruction with org.apache.sling.launchpad.base.* and add an Export-Package instruction.
> HOWEVER, the manifest that results from this is slightly different than the one produced prior to r892734. Specifically, it no longer has a Private-Package header. I'm not really sure why this is, but it doesn't seem to be a problem.
> diff --git a/launchpad/base/pom.xml b/launchpad/base/pom.xml
> index 2c5364d..8180955 100644
> --- a/launchpad/base/pom.xml
> +++ b/launchpad/base/pom.xml
> @@ -69,8 +69,9 @@
> !org.apache.sling.launchpad.app.*,
> !org.apache.sling.launchpad.base.shared.*,
> !org.apache.sling.launchpad.webapp.*,
> - *
> + org.apache.sling.launchpad.base.*
> </Private-Package>
> + <Export-Package>!*</Export-Package>
> <Import-Package>!*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <Embed-Dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-1254) Change from maven-bundle-plugin 1.4.3
to 2.0.1 causes launchpad.base.jar to have too much stuff in it
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-1254:
----------------------------------------
Assignee: Felix Meschberger
> Change from maven-bundle-plugin 1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-1254
> URL: https://issues.apache.org/jira/browse/SLING-1254
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Priority: Critical
>
> After r892734, the launchpad base jar has more content in it than it should (850 files instead 269 files). Most significantly, the contents of org.apache.sling.launchpad.base.shared are included which causes this exception:
> > org.osgi.framework.BundleException: sling.home property is missing, cannot start
> This appears to be because of a change in behavior in the maven-bundle-plugin between 1.4.3 and 2.0.1.
> The fix is to replace the last line in the Private-Package instruction with org.apache.sling.launchpad.base.* and add an Export-Package instruction.
> HOWEVER, the manifest that results from this is slightly different than the one produced prior to r892734. Specifically, it no longer has a Private-Package header. I'm not really sure why this is, but it doesn't seem to be a problem.
> diff --git a/launchpad/base/pom.xml b/launchpad/base/pom.xml
> index 2c5364d..8180955 100644
> --- a/launchpad/base/pom.xml
> +++ b/launchpad/base/pom.xml
> @@ -69,8 +69,9 @@
> !org.apache.sling.launchpad.app.*,
> !org.apache.sling.launchpad.base.shared.*,
> !org.apache.sling.launchpad.webapp.*,
> - *
> + org.apache.sling.launchpad.base.*
> </Private-Package>
> + <Export-Package>!*</Export-Package>
> <Import-Package>!*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <Embed-Dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1254) Change from maven-bundle-plugin 1.4.3
to 2.0.1 causes launchpad.base.jar to have too much stuff in it
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-1254.
-----------------------------------
Resolution: Fixed
> Change from maven-bundle-plugin 1.4.3 to 2.0.1 causes launchpad.base.jar to have too much stuff in it
> -----------------------------------------------------------------------------------------------------
>
> Key: SLING-1254
> URL: https://issues.apache.org/jira/browse/SLING-1254
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Priority: Critical
>
> After r892734, the launchpad base jar has more content in it than it should (850 files instead 269 files). Most significantly, the contents of org.apache.sling.launchpad.base.shared are included which causes this exception:
> > org.osgi.framework.BundleException: sling.home property is missing, cannot start
> This appears to be because of a change in behavior in the maven-bundle-plugin between 1.4.3 and 2.0.1.
> The fix is to replace the last line in the Private-Package instruction with org.apache.sling.launchpad.base.* and add an Export-Package instruction.
> HOWEVER, the manifest that results from this is slightly different than the one produced prior to r892734. Specifically, it no longer has a Private-Package header. I'm not really sure why this is, but it doesn't seem to be a problem.
> diff --git a/launchpad/base/pom.xml b/launchpad/base/pom.xml
> index 2c5364d..8180955 100644
> --- a/launchpad/base/pom.xml
> +++ b/launchpad/base/pom.xml
> @@ -69,8 +69,9 @@
> !org.apache.sling.launchpad.app.*,
> !org.apache.sling.launchpad.base.shared.*,
> !org.apache.sling.launchpad.webapp.*,
> - *
> + org.apache.sling.launchpad.base.*
> </Private-Package>
> + <Export-Package>!*</Export-Package>
> <Import-Package>!*</Import-Package>
> <DynamicImport-Package>*</DynamicImport-Package>
> <Embed-Dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.