You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/24 19:00:43 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #6109: Parallelise collect_partitioned
tustvold opened a new pull request, #6109:
URL: https://github.com/apache/arrow-datafusion/pull/6109
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This makes it consistent with RepartitionExec and CoalescePartitionsExec
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #6109: Parallelise collect_partitioned
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #6109:
URL: https://github.com/apache/arrow-datafusion/pull/6109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6109: Parallelise collect_partitioned
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #6109:
URL: https://github.com/apache/arrow-datafusion/pull/6109#discussion_r1175678075
##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -443,11 +443,21 @@ pub async fn collect_partitioned(
context: Arc<TaskContext>,
) -> Result<Vec<Vec<RecordBatch>>> {
let streams = execute_stream_partitioned(plan, context)?;
- let mut batches = Vec::with_capacity(streams.len());
- for stream in streams {
- batches.push(common::collect(stream).await?);
- }
- Ok(batches)
+
+ // Execute the plan and collect the results into batches.
+ let handles = streams
+ .into_iter()
+ .enumerate()
+ .map(|(idx, stream)| async move {
+ let handle = tokio::task::spawn(stream.try_collect());
+ AbortOnDropSingle::new(handle).await.map_err(|e| {
+ DataFusionError::Execution(format!(
+ "collect_partitioned partition {idx} panicked: {e}"
+ ))
+ })?
+ });
+
+ futures::future::try_join_all(handles).await
Review Comment:
Using try_join_all will abort on first error as opposed to `join_all` which would collect them all and then discard all but the first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6109: Parallelise collect_partitioned
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6109:
URL: https://github.com/apache/arrow-datafusion/pull/6109#issuecomment-1520727603
Thank you @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6109: Parallelise collect_partitioned
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #6109:
URL: https://github.com/apache/arrow-datafusion/pull/6109#discussion_r1175678075
##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -443,11 +443,21 @@ pub async fn collect_partitioned(
context: Arc<TaskContext>,
) -> Result<Vec<Vec<RecordBatch>>> {
let streams = execute_stream_partitioned(plan, context)?;
- let mut batches = Vec::with_capacity(streams.len());
- for stream in streams {
- batches.push(common::collect(stream).await?);
- }
- Ok(batches)
+
+ // Execute the plan and collect the results into batches.
+ let handles = streams
+ .into_iter()
+ .enumerate()
+ .map(|(idx, stream)| async move {
+ let handle = tokio::task::spawn(stream.try_collect());
+ AbortOnDropSingle::new(handle).await.map_err(|e| {
+ DataFusionError::Execution(format!(
+ "collect_partitioned partition {idx} panicked: {e}"
+ ))
+ })?
+ });
+
+ futures::future::try_join_all(handles).await
Review Comment:
Using try_join_all will abort on first error as opposed to `join_all` which would run the execution to completion, and then discard everything but the first error if any
##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -443,11 +443,21 @@ pub async fn collect_partitioned(
context: Arc<TaskContext>,
) -> Result<Vec<Vec<RecordBatch>>> {
let streams = execute_stream_partitioned(plan, context)?;
- let mut batches = Vec::with_capacity(streams.len());
- for stream in streams {
- batches.push(common::collect(stream).await?);
- }
- Ok(batches)
+
+ // Execute the plan and collect the results into batches.
+ let handles = streams
+ .into_iter()
+ .enumerate()
+ .map(|(idx, stream)| async move {
+ let handle = tokio::task::spawn(stream.try_collect());
+ AbortOnDropSingle::new(handle).await.map_err(|e| {
+ DataFusionError::Execution(format!(
+ "collect_partitioned partition {idx} panicked: {e}"
+ ))
+ })?
+ });
+
+ futures::future::try_join_all(handles).await
Review Comment:
Using `try_join_all` will abort on first error as opposed to `join_all` which would run the execution to completion, and then discard everything but the first error if any
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org