You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ripple.apache.org by "Brent Lintner (JIRA)" <ji...@apache.org> on 2013/07/05 23:27:48 UTC
[jira] [Closed] (RIPPLE-10) `ripple emulate` should return proper
404 when a .html file is not found
[ https://issues.apache.org/jira/browse/RIPPLE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brent Lintner closed RIPPLE-10.
-------------------------------
Closed PR. Fixed with: eb098f2aa27486a1bf6c13d0e457060981f13c10
> `ripple emulate` should return proper 404 when a .html file is not found
> ------------------------------------------------------------------------
>
> Key: RIPPLE-10
> URL: https://issues.apache.org/jira/browse/RIPPLE-10
> Project: Apache Ripple
> Issue Type: Bug
> Environment: CLI, NPM
> Reporter: Brent Lintner
> Assignee: Brent Lintner
> Priority: Minor
> Labels: v0.9.16
>
> Steps to reproduce:
> 1. Install v0.9.16
> 2. Run `ripple emulate --path simple-app/`
> Note: make sure simple-app does not have foo.html in it.
> 3. Open a browser and navigate to "localhost:4400/foo.html"
> Expected: Something like "Cannot GET /foo.html"
> Actually: It returns a (gracefully handled) server error:
> TypeError: path must be a string
> at Object.fs.open (fs.js:330:11)
> at Object.fs.readFile (fs.js:116:6)
> at inject (/Users/brent/local/node/lib/node_modules/ripple-emulator/lib/server/emulate/hosted.js:127:12)
> at Object.handle (/Users/brent/local/node/lib/node_modules/ripple-emulator/lib/server/emulate/hosted.js:152:13)
> at next (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/node_modules/connect/lib/proto.js:199:15)
> at next (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/node_modules/connect/lib/proto.js:174:78)
> at pass (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/lib/router/index.js:107:24)
> at Router._dispatch (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/lib/router/index.js:170:5)
> at Object.router (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/lib/router/index.js:33:10)
> at next (/Users/brent/local/node/lib/node_modules/ripple-emulator/node_modules/express/node_modules/connect/lib/proto.js:199:15)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira