You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2015/12/12 10:58:26 UTC
Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp 3f199e6
src/tests/master_tests.cpp 865fa4a
src/tests/master_validation_tests.cpp fbf8fad
src/tests/monitor_tests.cpp a848d14
src/tests/reservation_endpoints_tests.cpp d5d2aa7
src/tests/slave_recovery_tests.cpp c0e4ff7
src/tests/slave_tests.cpp 4975bea
Diff: https://reviews.apache.org/r/41308/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/#review110122
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41302, 41305, 41306, 41308]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 12, 2015, 9:58 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41308/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 9:58 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e6
> src/tests/master_tests.cpp 865fa4a
> src/tests/master_validation_tests.cpp fbf8fad
> src/tests/monitor_tests.cpp a848d14
> src/tests/reservation_endpoints_tests.cpp d5d2aa7
> src/tests/slave_recovery_tests.cpp c0e4ff7
> src/tests/slave_tests.cpp 4975bea
>
> Diff: https://reviews.apache.org/r/41308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Jan. 13, 2016, 4:39 a.m., Klaus Ma wrote:
> > @Joseph/Vinod, would you help to review those patches move executor from slave to master?
There are still several open issues open on each prior review. Can you go through and make sure those are addressed?
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/#review114191
-----------------------------------------------------------
On Dec. 12, 2015, 1:58 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41308/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 1:58 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e6
> src/tests/master_tests.cpp 865fa4a
> src/tests/master_validation_tests.cpp fbf8fad
> src/tests/monitor_tests.cpp a848d14
> src/tests/reservation_endpoints_tests.cpp d5d2aa7
> src/tests/slave_recovery_tests.cpp c0e4ff7
> src/tests/slave_tests.cpp 4975bea
>
> Diff: https://reviews.apache.org/r/41308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 13, 2016, 8:39 p.m., Klaus Ma wrote:
> > @Joseph/Vinod, would you help to review those patches move executor from slave to master?
>
> Joseph Wu wrote:
> There are still several open issues open on each prior review. Can you go through and make sure those are addressed?
Honestly, I'd like you to help review the code diff about executor's resources: where should get command line executor's resources? cut from tasks or add additional resources to it.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/#review114191
-----------------------------------------------------------
On Dec. 12, 2015, 5:58 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41308/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 5:58 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e6
> src/tests/master_tests.cpp 865fa4a
> src/tests/master_validation_tests.cpp fbf8fad
> src/tests/monitor_tests.cpp a848d14
> src/tests/reservation_endpoints_tests.cpp d5d2aa7
> src/tests/slave_recovery_tests.cpp c0e4ff7
> src/tests/slave_tests.cpp 4975bea
>
> Diff: https://reviews.apache.org/r/41308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master.
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 13, 2016, 8:39 p.m., Klaus Ma wrote:
> > @Joseph/Vinod, would you help to review those patches move executor from slave to master?
>
> Joseph Wu wrote:
> There are still several open issues open on each prior review. Can you go through and make sure those are addressed?
>
> Klaus Ma wrote:
> Honestly, I'd like you to help review the code diff about executor's resources: where should get command line executor's resources? cut from tasks or add additional resources to it.
@Joseph, the patches are rebased and commnets are addressed :). Would you help to reivew it?
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/#review114191
-----------------------------------------------------------
On Jan. 18, 2016, 10:19 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41308/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 10:19 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
>
>
> Diffs
> -----
>
> src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422
> src/tests/containerizer/docker_containerizer_tests.cpp a1a44daae68e5a4c6961e13ee9e16207c5d54768
> src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97
> src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198
> src/tests/master_tests.cpp aa0e0d8087175e3a3ed5b63a23d31aa6fe00d1b3
> src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
> src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
> src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
> src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840
>
> Diff: https://reviews.apache.org/r/41308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/#review114191
-----------------------------------------------------------
@Joseph/Vinod, would you help to review those patches move executor from slave to master?
- Klaus Ma
On Dec. 12, 2015, 5:58 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41308/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 5:58 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e6
> src/tests/master_tests.cpp 865fa4a
> src/tests/master_validation_tests.cpp fbf8fad
> src/tests/monitor_tests.cpp a848d14
> src/tests/reservation_endpoints_tests.cpp d5d2aa7
> src/tests/slave_recovery_tests.cpp c0e4ff7
> src/tests/slave_tests.cpp 4975bea
>
> Diff: https://reviews.apache.org/r/41308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/#review114676
-----------------------------------------------------------
Bad patch!
Reviews applied: [41302]
Failed command: ./support/apply-review.sh -n -r 41302
Error:
2016-01-15 07:25:53 URL:https://reviews.apache.org/r/41302/diff/raw/ [1701/1701] -> "41302.patch" [1]
No files to lint
Error: Commit message summary (the first line) must end in a period.
- Mesos ReviewBot
On Jan. 15, 2016, 5:19 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41308/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 5:19 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
>
>
> Diffs
> -----
>
> src/master/master.cpp 863a11c82d322f56db1ccf25b73a4ffff1304a46
> src/tests/containerizer/docker_containerizer_tests.cpp cb58b7183c36d96b9ac4803c63980c278a50c97b
> src/tests/master_tests.cpp 9638fb867b07f85a02d3b78f8282843d8871cabe
> src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
> src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
> src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa
>
> Diff: https://reviews.apache.org/r/41308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:55 a.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Changes
-------
rebase for apply conflict
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
Diffs (updated)
-----
src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422
src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397
src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97
src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e
src/tests/master_tests.cpp aa0e0d8087175e3a3ed5b63a23d31aa6fe00d1b3
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840
Diff: https://reviews.apache.org/r/41308/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/#review115023
-----------------------------------------------------------
Bad patch!
Reviews applied: [41302, 41305]
Failed command: ./support/apply-review.sh -n -r 41305
Error:
2016-01-18 17:03:08 URL:https://reviews.apache.org/r/41305/diff/raw/ [18732/18732] -> "41305.patch" [1]
error: patch failed: src/slave/slave.cpp:3442
error: src/slave/slave.cpp: patch does not apply
- Mesos ReviewBot
On Jan. 18, 2016, 2:19 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41308/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 2:19 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
>
>
> Diffs
> -----
>
> src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422
> src/tests/containerizer/docker_containerizer_tests.cpp a1a44daae68e5a4c6961e13ee9e16207c5d54768
> src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97
> src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198
> src/tests/master_tests.cpp aa0e0d8087175e3a3ed5b63a23d31aa6fe00d1b3
> src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
> src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
> src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
> src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840
>
> Diff: https://reviews.apache.org/r/41308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 10:19 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Changes
-------
rebase: add executorLost handler for command executor.
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
Diffs (updated)
-----
src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422
src/tests/containerizer/docker_containerizer_tests.cpp a1a44daae68e5a4c6961e13ee9e16207c5d54768
src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97
src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198
src/tests/master_tests.cpp aa0e0d8087175e3a3ed5b63a23d31aa6fe00d1b3
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840
Diff: https://reviews.apache.org/r/41308/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/
-----------------------------------------------------------
(Updated Jan. 16, 2016, noon)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Changes
-------
Add period to old summary.
Summary (updated)
-----------------
MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
Diffs
-----
src/master/master.cpp 863a11c82d322f56db1ccf25b73a4ffff1304a46
src/tests/containerizer/docker_containerizer_tests.cpp cb58b7183c36d96b9ac4803c63980c278a50c97b
src/tests/master_tests.cpp 9638fb867b07f85a02d3b78f8282843d8871cabe
src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa
Diff: https://reviews.apache.org/r/41308/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41308: MESOS-1718: Unit Test for moving
getExecutorInfo from slave to master
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 1:19 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Changes
-------
rebase
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: Unit Test for moving getExecutorInfo from slave to master
Diffs (updated)
-----
src/master/master.cpp 863a11c82d322f56db1ccf25b73a4ffff1304a46
src/tests/containerizer/docker_containerizer_tests.cpp cb58b7183c36d96b9ac4803c63980c278a50c97b
src/tests/master_tests.cpp 9638fb867b07f85a02d3b78f8282843d8871cabe
src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f
src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa
Diff: https://reviews.apache.org/r/41308/diff/
Testing
-------
Thanks,
Klaus Ma