You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/09/06 11:31:21 UTC
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on issue #534:
Fix inappbrowser not opening on iOS 13 by using reusable window
jcesarmobile commented on issue #534: Fix inappbrowser not opening on iOS 13 by using reusable window
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/534#issuecomment-528818832
I think the problem is the UIWebView open code has been changed a lot of times reintroducing the mentioned bug, so by making them equal you've propagated the bug to the WKWebView implementation.
They key part of the fix was to have a reference to the tmpWindow, so you can do that in the PR without changing the whole code to match the UIWebView code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org