[GitHub] [helix] jiajunwang commented on a change in pull request #696: Add WAGED rebalancer reset method to clean up cached status.

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #696: Add WAGED rebalancer reset method to clean up cached status.
URL: https://github.com/apache/helix/pull/696#discussion_r370309107
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -177,12 +172,13 @@ private WagedRebalancer(AssignmentMetadataStore assignmentMetadataStore,
     _assignmentMetadataStore = assignmentMetadataStore;
     _rebalanceAlgorithm = algorithm;
     _mappingCalculator = mappingCalculator;
+    if (manager == null) {
+      LOG.warn("HelixManager is not provided. The rebalancer is not going to schedule for a future "
+          + "rebalance even when delayed rebalance is enabled.");
 
 Review comment:
   DelayedRebalance != delayed rebalance.
   WAGED rebalancer also supports delayed rebalance feature. We need to log it so when we debug we ensure if the delayed rebalance feature has been enabled or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org