[GitHub] [spark] cloud-fan commented on a change in pull request #35268: [SPARK-37950][SQL] Take EXTERNAL as a reserved table property

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35268:
URL: https://github.com/apache/spark/pull/35268#discussion_r789485847



##########
File path: docs/sql-migration-guide.md
##########
@@ -56,6 +56,8 @@ license: |
 
   - Since Spark 3.3, DESCRIBE FUNCTION fails if the function does not exist. In Spark 3.2 or earlier, DESCRIBE FUNCTION can still run and print "Function: func_name not found".
 
+  - Since Spark 3.3, the property `external` become reserved for table; commands fail if you specify `external` property in places like `CREATE TABLE ... TBLPROPERTIES` and `ALTER TABLE ... SET TBLPROPERTIES`. You can set `spark.sql.legacy.notReserveProperties` to `true` to ignore the `ParseException`, in this case, `external` will be silently removed.

Review comment:
       ```suggestion
     - Since Spark 3.3, the table property `external` becomes reserved. Certain commands will fail if you specify the `external` property, such as `CREATE TABLE ... TBLPROPERTIES` and `ALTER TABLE ... SET TBLPROPERTIES`. In Spark 3.2 and earlier, the table property `external` is silently ignored. You can set `spark.sql.legacy.notReserveProperties` to `true` to restore the old behavior.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org