You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ignacio Vera (JIRA)" <ji...@apache.org> on 2017/12/01 17:07:00 UTC

[jira] [Comment Edited] (LUCENE-8071) GeoExactCircle should create circles with right number of planes

    [ https://issues.apache.org/jira/browse/LUCENE-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274624#comment-16274624 ] 

Ignacio Vera edited comment on LUCENE-8071 at 12/1/17 5:06 PM:
---------------------------------------------------------------

Thanks for committing [~karl wright],

Fair to say that the shape only supports planets which are slightly elongated like WGS84 (~abs(flattening)<0.05). 

I attach the test I am using to check the shape in case you think it is useful. I will move this shape to the spatial4j wrapper if it is ok with you.



was (Author: ivera):
Thanks for committing [~karl wright],

Fair to say that the shape only supports planets which are slightly elongated like WGS84 (~abs(flattening)<0.1). 

I attach the test I am using to check the shape in case you think it is useful. I will move this shape to the spatial4j wrapper if it is ok with you.


> GeoExactCircle should  create circles with right number of planes
> -----------------------------------------------------------------
>
>                 Key: LUCENE-8071
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8071
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>             Fix For: 6.7, master (8.0), 7.2
>
>         Attachments: LUCENE-8071-test.patch, LUCENE-8071.patch, testPointsWithIn.patch
>
>
> Hi [~kwright@metacarta.com],
> There is still a situation when the test can fail. It happens when the planet model is a SPHERE and the radius is slightly lower than PI. The circle is created with two sectors but the circle plane is too big and the shape is bogus.
> I will attach a test and a proposed solution. (I hope this is the last issue of this saga)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org