You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/07/07 00:39:48 UTC
[jira] [Commented] (BOOKKEEPER-638) Two bookies could start at the
same time to access bookie data.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701436#comment-13701436 ]
Hadoop QA commented on BOOKKEEPER-638:
--------------------------------------
Testing JIRA BOOKKEEPER-638
Patch [BOOKKEEPER-638.diff|https://issues.apache.org/jira/secure/attachment/12591096/BOOKKEEPER-638.diff] downloaded at Sat Jul 6 22:11:22 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 853
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/411/
> Two bookies could start at the same time to access bookie data.
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-638
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-638
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.3.0
> Reporter: Sijie Guo
> Priority: Blocker
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-638.diff
>
>
> this issue is introduced in providing netty server for bookie.
> in BOOKKEEPER-294, we agreed on the start sequence of bookie:
> 1) bind bookie port first (to avoid two processes running at the same host).
> 2) start bookie (e.g initialize bookie storage and replaying journals)
> 3) start nio server to accept incoming requests.
> but after refactoring for netty server, step 1) is combined to be executed in step 3), so two processes could have chance to run at the same time replaying journals. this is pretty bad.
> we need to change the code to stick on the sequence described above.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira