You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/18 21:22:56 UTC
[GitHub] [kafka] tguruprasad opened a new pull request #9767: KAFKA-10047: Remove unnecessary widening of (int to long) scope in FloatSerializer.
tguruprasad opened a new pull request #9767:
URL: https://github.com/apache/kafka/pull/9767
@halorgium @astubbs @alexism @glasser @rhardouin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9767: KAFKA-10047: Remove unnecessary widening of (int to long) scope in FloatSerializer.
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9767:
URL: https://github.com/apache/kafka/pull/9767#issuecomment-748433375
Also, KAFKA-10047 already has a PR (https://github.com/apache/kafka/pull/9351). If you want to create a PR for it, it would be better to ask the author of PR (or reporter of jira) if they don't work on it anymore. If so, it is ok to take over the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9767: KAFKA-10047: Remove unnecessary widening of (int to long) scope in FloatSerializer.
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9767:
URL: https://github.com/apache/kafka/pull/9767#issuecomment-748432898
@tguruprasad It would be better to ping author or kafka active committers to review code :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tguruprasad commented on pull request #9767: KAFKA-10047: Remove unnecessary widening of (int to long) scope in FloatSerializer.
Posted by GitBox <gi...@apache.org>.
tguruprasad commented on pull request #9767:
URL: https://github.com/apache/kafka/pull/9767#issuecomment-748423867
Apologizes for spamming folks who are tagged. As mentioned in [this wiki](https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes), I selected GitHub's automatic suggestions to tag the folks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tguruprasad closed pull request #9767: KAFKA-10047: Remove unnecessary widening of (int to long) scope in FloatSerializer.
Posted by GitBox <gi...@apache.org>.
tguruprasad closed pull request #9767:
URL: https://github.com/apache/kafka/pull/9767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] glasser commented on pull request #9767: KAFKA-10047: Remove unnecessary widening of (int to long) scope in FloatSerializer.
Posted by GitBox <gi...@apache.org>.
glasser commented on pull request #9767:
URL: https://github.com/apache/kafka/pull/9767#issuecomment-748376004
I'm not sure why I'm tagged; did you mean somebody else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tguruprasad commented on pull request #9767: KAFKA-10047: Remove unnecessary widening of (int to long) scope in FloatSerializer.
Posted by GitBox <gi...@apache.org>.
tguruprasad commented on pull request #9767:
URL: https://github.com/apache/kafka/pull/9767#issuecomment-748502435
@chia7712 thanks for pointing out the existing PR. Since I had created and assigned JIRA to myself I didn't realized someone has made fix for it. Let me close this PR and keep the existing PR open. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org