You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/02/20 11:08:33 UTC
[GitHub] [logging-log4j2] ruhulmus opened a new pull request #763: Added java logging with Asynchronous logger
ruhulmus opened a new pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763
log4j2 logging using java 8 and maven 3
Implement Asynchronous Loggers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046214567
@ruhulmus
Please describe what is the goal of this PR. It does not seem to fit in the project. Why a new module and so on? None of the files have the proper Apache license header as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046265712
Hello @ruhulmus
This looks like an example app and configuration. I do not see why it belongs in the Log4j runtime. What am I missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810680609
##########
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
OK, the package name is just an example name (I just make a demo name for it ).
I have made 2 classes (Main and Error class)
Both classes are used for logging.
The Main class is responsible for Debug logging and the Error Class is mainly used for error logging.
If you think it's confusing I can rename the package and class name for a better understanding. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810678883
##########
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
What is the point of this class?
FTR: No Javadoc. Wrong package anyway.
It feels like there is a disconnect between what should be an example and your expectations. -1 unless someone can explain why we need this class or this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##########
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
And the configuration of Async logging is done here: [log4j-java-maven/src/main/resources/log4j2-async.xml](https://github.com/apache/logging-log4j2/pull/763/files/b7adc73375a7c886f90d9ab87f8904270d878bf0#diff-5290387af67800f016c88f9f5db1faa8d37d91ad09bb44019b0506c711ce1ad5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##########
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
And the configuration of Async logging is done here : log4j-java-maven/src/main/resources/log4j2-async.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##########
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046775984
> @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the docs? What does it add that the existing docs are missing? (And would it be an idea to improve the existing docs, if that is the case.)
@remkop, I have moved the projects under the Docs directory and made detailed documentation with examples for the user's better understanding. I believe it will be helpful for the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046217637
> @ruhulmus Please describe what is the goal of this PR. It does not seem to fit in the project. Why a new module and so on? None of the files have the proper Apache license header as well.
Thanks for your feedback. The goal of this PR is mainly to add Asynchronous Loggers for Low-Latency Logging into Java maven-based project.
here is the link: https://logging.apache.org/log4j/2.x/manual/async.html
N.B : Already Added Apache license in the headers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus edited a comment on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus edited a comment on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046311284
> Hello @ruhulmus This looks like an example app and configuration. I do not see why it belongs in the Log4j runtime. What am I missing?
Here, logs are running Asynchronously using Log4j on the java maven project. Async logger is one of Log4j2's strong points.
And it belongs in the Log4j runtime.
This mechanism increased the logging performance and provide lower logging latency and higher throughput.
I hope now it's bit clear :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1047809689
@remkop, Could you please review the changes? I have made updates based on the last discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##########
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
And the configuration of Async logging is done here: [log4j-java-maven/src/main/resources/log4j2-async.xml](https://github.com/apache/logging-log4j2/pull/763/files/b7adc73375a7c886f90d9ab87f8904270d878bf0#diff-ee17432c0d86feb0074d792a5ff699f2259f58ee17bc2fb7752e8dc30efc8c58)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] remkop commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
remkop commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046326417
@ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the docs? What does it add that the existing docs are missing? (And would it be an idea to improve the existing docs, if that is the case.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046521980
> @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the docs? What does it add that the existing docs are missing? (And would it be an idea to improve the existing docs, if that is the case.)
Ok Sure, Then I will move into the right sections and can make a details doc. so anyone can better understand.
The main reason to share it within the community, it's an important use case for log4j2, especially in java based projects.
Thanks for your feedback :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus commented on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046311284
> Hello @ruhulmus This looks like an example app and configuration. I do not see why it belongs in the Log4j runtime. What am I missing?
Here, logs are running Asynchronously using Log4j on the java maven project. Async logger is one of Log4j2's strong points.
And it belongs in the Log4j runtime.
This mechanism increased the logging performance and provide lower logging latency and higher throughput.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus edited a comment on pull request #763: Added java logging with Asynchronous logger
Posted by GitBox <gi...@apache.org>.
ruhulmus edited a comment on pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046775984
> @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the docs? What does it add that the existing docs are missing? (And would it be an idea to improve the existing docs, if that is the case.)
@remkop, I have moved the project under the Docs directory and made detailed documentation with examples for the user's better understanding. I believe it will be helpful for the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org