You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "whhe (via GitHub)" <gi...@apache.org> on 2024/03/28 07:19:06 UTC
[PR] hotfix(ui): fix databaseTypes following the DbType in spi module [dolphinscheduler]
whhe opened a new pull request, #15776:
URL: https://github.com/apache/dolphinscheduler/pull/15776
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
Add 'OCEANBASE' and update other items to keep them same with enum [DbType](https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/DbType.java).
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
Fix datasource list in ui.
## Verify this pull request
Test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug][ui] add missing datasource and update datasource id [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15776:
URL: https://github.com/apache/dolphinscheduler/pull/15776#issuecomment-2024626389
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15776) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15776&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15776&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15776&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15776&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15776)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug][ui] add missing datasource and update datasource id [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #15776:
URL: https://github.com/apache/dolphinscheduler/pull/15776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug][ui] add missing datasource and update datasource id [dolphinscheduler]
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #15776:
URL: https://github.com/apache/dolphinscheduler/pull/15776#issuecomment-2026520051
> Please link to issue. @whhe
Hi @SbloodyS, the issue has been created and linked to this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hotfix(ui): fix databaseTypes following the DbType in spi module [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15776:
URL: https://github.com/apache/dolphinscheduler/pull/15776#issuecomment-2024586505
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 39.10%. Comparing base [(`5e3dc7b`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/5e3dc7b16ffe8bdf2e06518d4c7080bd39ba228d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b54806c`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15776?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on dev.
> :exclamation: Current head b54806c differs from pull request most recent head ba0aec9. Consider uploading reports for the commit ba0aec9 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #15776 +/- ##
============================================
- Coverage 39.10% 39.10% -0.01%
+ Complexity 4854 4852 -2
============================================
Files 1316 1316
Lines 44945 44910 -35
Branches 4800 4777 -23
============================================
- Hits 17577 17560 -17
+ Misses 25478 25458 -20
- Partials 1890 1892 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15776?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug][ui] add missing datasource and update datasource id [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15776:
URL: https://github.com/apache/dolphinscheduler/pull/15776#issuecomment-2024626935
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15776) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15776&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15776&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15776&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15776&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15776)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org