[jira] [Commented] (THRIFT-3205) TCompactProtocol return a wrong error when the io.EOF happens

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602623#comment-14602623 ] 

ASF GitHub Bot commented on THRIFT-3205:
----------------------------------------

GitHub user wangjild opened a pull request:

    https://github.com/apache/thrift/pull/530

    fix THRIFT-3205

    TCompactProtocol return a wrong error when the io.EOF happens

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangjild/thrift THRIFT-3205

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #530
    
----
commit fa918a674d5c15c137e085318bf653cb8e9f27f1
Author: Wang Jing <wa...@bytedance.com>
Date:   2015-06-26T09:37:28Z

    fix THRIFT-3205

----


> TCompactProtocol return a wrong error when the io.EOF happens
> -------------------------------------------------------------
>
>                 Key: THRIFT-3205
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3205
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>    Affects Versions: 0.9.2
>            Reporter: Jing Wang
>             Fix For: 0.9.3
>
>
> When Transport return a io error, TCompactProtocol.ReadMessageBegin method will not process these error firstly, and cause the protocol returned a wrong error:  
>       fmt.Errorf("Expected protocol id %02x but got %02x", COMPACT_PROTOCOL_ID, protocolId)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)