You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/17 19:01:02 UTC

[GitHub] [pinot] dongxiaoman commented on pull request #8813: Adding support for broker routing queries to other tenants

dongxiaoman commented on PR #8813:
URL: https://github.com/apache/pinot/pull/8813#issuecomment-1159154064

   @xiangfu0 
   My main concern is the broker query performance hit or CPU waste because Query String is parsed. It may be small cost for some queries but may also be a lot for some cases.
   
   Another possible (extra) approach:
   1. allow the user to specify table name in extra header `x-pinot-tables: airlinestats, meetupRSVP`
   2. trust the user's intent, forward to the right tenant before parsing query 
   3. if query is already forwarded, and tenant is wrong, reject the query. This step will check whether user is honest enough
   
   This way if the user really cares about extra overhead, they can manually go through the trouble to set the table name in header. If they don't care, they can just let us parse the query.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org