You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/10/01 19:58:41 UTC

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #262: Unordered sequences

mbeckerle commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r330244756
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala
 ##########
 @@ -224,12 +227,22 @@ abstract class OrderedSequenceParserBase(
               pstate.setSuccess()
               isDone = true
             }
+            case (MissingItem | MissingSeparator | FailureUnspecified) if (!isOrdered) => {
+              pstate.setSuccess()
 
 Review comment:
   Add a comment here as to why for unordered these failure conditions are ok, which I think is because in general unordered stuff behaves like occursCountKind parsed, i.e., it parses until something stops it by a failure. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services