You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/22 15:19:00 UTC
[GitHub] [kafka] dongjinleekr opened a new pull request #10176: KAFKA-12359: Update Jetty to 11
dongjinleekr opened a new pull request #10176:
URL: https://github.com/apache/kafka/pull/10176
1. Add new dependency.
- javax.ws.rs:jsr311-api:1.1.1
- jakarta.servlet:jakarta.servlet-api:5.0.0
2. Update the Java EE related dependency names. see: [#1](https://webtide.com/renaming-from-javax-to-jakarta/) [#2](https://wiki.eclipse.org/Jakarta_EE_Maven_Coordinates)
- javax.activation:activation:1.1.1 -> com.sun.activation:javax.activation:1.2.0
- javax.ws.rs:javax.ws.rs-api 2.1.1 -> jakarta.ws.rs:jakarta.ws.rs-api 3.0.0.
- javax.xml.bind:jaxb-api:2.3.0 -> jakarta.xml.bind:jakarta.xml.bind-api:2.3.0
3. Change all `javax.ws.rs.*` imports into `jakarta.ws.rs.*`.
4. Make Jackson to be compatible with new Jakarta API.
- Add jakarta classifier to jackson-jaxrs-json-provider for compatibility with jakarta.ws.rs-api.
- Add org.glassfish.jersey.media:jersey-media-json-jackson:3.0.1 dependency for registering jackson as a `MessageBodyWriter`.
5. Upgrade jersey from 2.31 to 3.0.1.
6. Upgrade Jetty to 11.0.0 and apply the API changes.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #10176: KAFKA-12359: Update Jetty to 11
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10176:
URL: https://github.com/apache/kafka/pull/10176#issuecomment-851818497
For those who are interested in this issue, here is some context:
As you can see in the table below (from [here](https://www.eclipse.org/jetty/)), the change between Jetty 9.4 and Jetty 11 is not only Servlet versions; it involves Servlet version, package namespace, API changes, and related dependencies. For this reason, Upgrading Jetty from 9.4 is never a simple task but a complicated one that requires lots of changes, tests, etc.
The problem is: **the current 9.4's End of Life seems not a too distant future**; For instance, [Jetty 9.2 reached the end of life in March 2018](https://www.eclipse.org/lists/jetty-announce/msg00116.html), and [9.3 also did in February 2020](https://www.eclipse.org/lists/jetty-announce/msg00140.html) (i.e., in two years). 9.3 also dropped Java 7 support from before its final release. Although the Jetty team does not mention it explicitly, the community seems to expect it to reach the EOL in 2022 when Jetty 10.x and 11.x becomes stable and widespread. If this thing happens, we should also migrate to Jetty 11, along with Java 11.
I agree with @ijuma that it is too early to discuss this issue. However, I think we have enough reason to recognize this problem. **I will keep my eyes on Jetty 9.4's EOL issue and as soon as it becomes certain, I will reopen the PR.**
+1. For those who hope to test Kafka Connect on Servlet 5: I will start providing a preview soon like [log4j2 appender](http://home.apache.org/~dongjin/post/apache-kafka-log4j2-support/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10176: KAFKA-12359: Update Jetty to 11
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10176:
URL: https://github.com/apache/kafka/pull/10176#issuecomment-849652409
We are not planning to upgrade to Java 11 any time soon. Can you please submit a PR for the latest Jetty version that supports Java 8 still?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #10176: KAFKA-12359: Update Jetty to 11
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10176:
URL: https://github.com/apache/kafka/pull/10176#issuecomment-813274930
For those who are curious about how the Jetty 11 upgrade would be, here is the latest draft with Jetty 11.0.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #10176: KAFKA-12359: Update Jetty to 11
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10176:
URL: https://github.com/apache/kafka/pull/10176#issuecomment-783451243
The first commit addresses the [Java 11 Migration (KAFKA-12358)](https://issues.apache.org/jira/browse/KAFKA-12358) issue. If the community decides to migrate into Java 11, I will separate it into an independent PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma closed pull request #10176: KAFKA-12359: Update Jetty to 11
Posted by GitBox <gi...@apache.org>.
ijuma closed pull request #10176:
URL: https://github.com/apache/kafka/pull/10176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org