You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/06/27 02:59:15 UTC
[GitHub] [spark] Hisoka-X opened a new pull request, #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Hisoka-X opened a new pull request, #41755:
URL: https://github.com/apache/spark/pull/41755
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR bring force finish stage feature to AQE, it used when some stage will useless when plan after reOptimize.
eg:
```sql
SELECT * FROM emptyTestData t1 LEFT OUTER JOIN testData t2 ON t1.key = t2.key
```
The left table data is emtpy, so the right table data will be useless, unnecessary continue to read right table.
It will save database/spark CPU and IO resource if right table is large.
The Spark UI display force finish like

<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
add new force finish feature to AQE
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
add new test
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41755:
URL: https://github.com/apache/spark/pull/41755#discussion_r1243155019
##########
project/MimaExcludes.scala:
##########
@@ -51,6 +51,8 @@ object MimaExcludes {
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.listTables"),
// [SPARK-43992][SQL][PYTHON][CONNECT] Add optional pattern for Catalog.listFunctions
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.listFunctions"),
+ // [SPARK-43999][SQL] Support force finish useless stage when AQE on
Review Comment:
I consider remove it now, doesn't look elegant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1659547491
> The problem is that, we can not predicate which exchange will be reused easily since AQE is adaptive. What if we cancel a running exchange but later we need to run another exchange which is semantic equivalent ?
I got your point. Thanks for explained! Before find a useable solution, I close this pr first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1609207288
The reason why I closed my pr is that we can not cancel a broadcast query stage because exchange reuse shares the broadcast future instance. It's ok to cancel a shuffle stage before executing final plan, but note that we can not cancel an intermediate shuffle stage to avoid breaking reuse shuffle exchange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41755:
URL: https://github.com/apache/spark/pull/41755#discussion_r1243151274
##########
project/MimaExcludes.scala:
##########
@@ -51,6 +51,8 @@ object MimaExcludes {
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.listTables"),
// [SPARK-43992][SQL][PYTHON][CONNECT] Add optional pattern for Catalog.listFunctions
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.listFunctions"),
+ // [SPARK-43999][SQL] Support force finish useless stage when AQE on
Review Comment:
really need this item?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1652759143
> The reason why I closed my pr is that we can not cancel a broadcast query stage because exchange reuse shares the broadcast future instance. It's ok to cancel a shuffle stage before executing final plan, but note that we can not cancel an intermediate shuffle stage to avoid breaking reuse shuffle exchange.
Sorry about late response. I don't think the current solution will cancel the reuse stage, because this PR decides whether to cancel it by judging whether there is still a reference to a stage in the PhysicalPlan. No reference means that he will not be reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1608811710
cc @cloud-fan @ulysses-you FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1609144566
> hmm...If I remember correctly, @ulysses-you submitted a pr with similar goals
Thanks @LuciferYang , I think you are talk about https://github.com/apache/spark/pull/41536/ . I think there are some different between two PR. @ulysses-you 's way will affect reuse exchange (I'm not sure this PR will or not, but according the CI, seem will not), this PR will force finish stage not cancel it. The behavior are different.
By the way, please search `Unnecessary Stage` in https://github.com/Hisoka-X/spark/actions/runs/5387239085/jobs/9778311879 or https://github.com/Hisoka-X/spark/actions/runs/5387239085/jobs/9778311577 . Some query already benefited from this PR.
Anyway, I'm not sure this way are best, only convert my thought to code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X closed pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X closed pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
URL: https://github.com/apache/spark/pull/41755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1657425386
The problem is that, we can not predicate which shuffle will be reused easily since AQE is adaptive. What if we cancel a running exchange but later we need to run another exchange which is semantic equivalent ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org