You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2018/04/11 22:49:29 UTC

[GitHub] spark pull request #21044: [SPARK-9312][ML] Add RawPrediction, numClasses, a...

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21044#discussion_r180920806
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
    @@ -195,14 +205,18 @@ final class OneVsRestModel private[ml] (
           newDataset.unpersist()
         }
     
    -    // output the index of the classifier with highest confidence as prediction
    -    val labelUDF = udf { (predictions: Map[Int, Double]) =>
    -      predictions.maxBy(_._2)._1.toDouble
    +    // output the RawPrediction as vector
    +    val rawPredictionUDF = udf { (predictions: Map[Int, Double]) =>
    +      Vectors.sparse(numClasses, predictions.toList )
    --- End diff --
    
    Also, let's output a dense Vector since it will almost surely be dense.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org