[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3447: TO Client: Alerts are not returned even when they exist?

[GitBox <gi...@apache.org>]

mitchell852 edited a comment on issue #3447: TO Client: Alerts are not returned even when they exist?
URL: https://github.com/apache/trafficcontrol/issues/3447#issuecomment-479968886
 
 
   maybe all of our current TO client consumers (Traffic Monitor, TO API test framework, Traffic Stats, Grove) don't really care about the "alerts" as they are really just text messages with an indicator of severity (error, warning, info, success) so the alerts node was never necessary for these client consumers hence it was never added to the TO client? however, since the TO client is a wrapper around the TO api, i think it makes sense to include `alerts`. imo this looks like tech debt.
   
   however, it might be brittle to make a test that checks the verbiage of the alert....maybe checking the severity of the alert would be better? your call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services