[GitHub] [spark] cloud-fan commented on a diff in pull request #38800: [SPARK-41264][CONNECT][PYTHON] Make Literal support more datatypes

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #38800:
URL: https://github.com/apache/spark/pull/38800#discussion_r1033281998


##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -40,37 +40,34 @@ message Expression {
 
   message Literal {
     oneof literal_type {

Review Comment:
   In catalyst, `Literal` is consist of value and type. The benefit is, there aren't many physical values (timestamp and timestamp ntz are both int64). When we need to add a new data type with existing physical values (e.g. char are varchar), we don't need to update `Literal`.
   
   This is not a design decision made by this PR, so I won't block this PR for this reason.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org