[jira] [Commented] (SOLR-12559) FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are involved

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546963#comment-16546963 ] 

Hoss Man commented on SOLR-12559:
---------------------------------

No trivially fix jumped out at me, because the "flags" used by FunctionQParser aren't an object property that can be set on the subprocessor ... they are only passed as a param directly to {{parseValueSource}}

> FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are involved
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-12559
>                 URL: https://issues.apache.org/jira/browse/SOLR-12559
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Facet Module
>            Reporter: Hoss Man
>            Priority: Major
>
> While working on a patch dealing with json facet syntax parsing, i was trying to write a test verifying the equivalence of 2 json facet requests that should be identical and discovered that when SOLR-10613 was implemented to defer the parsing of field names via {{FieldNameValueSource}} the implementation did not account for the invocation of sub parsers via param references.
> specifically -- this json facet request will produce two AggValueSources which are not {{equals()}}...
> {noformat}
> curl http://localhost:8983/solr/query -d 'q=*:*&my_field=foo_i&
> json.facet={
>   x : "min(foo_i)",
>   y : "min($my_field)"
> }'
> {noformat}
> "x" uses {{FieldNameValueSource}} while "y" directly uses an {{IntValueSource}}
> (It's not immediately obvious to me if this currently causes any user visible bugs or performance hicups, but it will definitely be problematic for users once we add support for {{min(multivalued_field_i)}} )



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org