You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/05/04 23:22:44 UTC

Review Request 59010: Updated protobuf comments for Image::Secret.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/
-----------------------------------------------------------

Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.


Repository: mesos


Description
-------

Updated protobuf comments for Image::Secret.


Diffs
-----

  include/mesos/mesos.proto 1935f47a52840f6b395ecb2d28296666551fa691 
  include/mesos/v1/mesos.proto c7f0bec5c96f2f41344d4261d0696f9fe0421db7 


Diff: https://reviews.apache.org/r/59010/diff/1/


Testing
-------

N/A.


Thanks,

Gilbert Song

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/
-----------------------------------------------------------

(Updated May 22, 2017, 10:56 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Updated protobuf comments for Image::Secret.


Diffs (updated)
-----

  include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154 
  include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3 


Diff: https://reviews.apache.org/r/59010/diff/3/

Changes: https://reviews.apache.org/r/59010/diff/2-3/


Testing
-------

N/A.


Thanks,

Gilbert Song

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/#review174249
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On May 5, 2017, 8:30 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59010/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated protobuf comments for Image::Secret.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1935f47a52840f6b395ecb2d28296666551fa691 
>   include/mesos/v1/mesos.proto c7f0bec5c96f2f41344d4261d0696f9fe0421db7 
> 
> 
> Diff: https://reviews.apache.org/r/59010/diff/2/
> 
> 
> Testing
> -------
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/
-----------------------------------------------------------

(Updated May 5, 2017, 1:30 p.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.


Repository: mesos


Description
-------

Updated protobuf comments for Image::Secret.


Diffs (updated)
-----

  include/mesos/mesos.proto 1935f47a52840f6b395ecb2d28296666551fa691 
  include/mesos/v1/mesos.proto c7f0bec5c96f2f41344d4261d0696f9fe0421db7 


Diff: https://reviews.apache.org/r/59010/diff/2/

Changes: https://reviews.apache.org/r/59010/diff/1-2/


Testing
-------

N/A.


Thanks,

Gilbert Song

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/#review174027
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Line 2140 (original), 2140 (patched)
<https://reviews.apache.org/r/59010/#comment247129>

    This field has never been...



include/mesos/v1/mesos.proto
Line 2134 (original), 2134 (patched)
<https://reviews.apache.org/r/59010/#comment247130>

    Same here.


- Chun-Hung Hsiao


On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59010/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 11:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated protobuf comments for Image::Secret.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1935f47a52840f6b395ecb2d28296666551fa691 
>   include/mesos/v1/mesos.proto c7f0bec5c96f2f41344d4261d0696f9fe0421db7 
> 
> 
> Diff: https://reviews.apache.org/r/59010/diff/1/
> 
> 
> Testing
> -------
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>