You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/15 04:48:45 UTC
[GitHub] [solr] dsmiley opened a new pull request, #1013: SOLR-15342 Solrj-Zookeeper: opt-out on 9x
dsmiley opened a new pull request, #1013:
URL: https://github.com/apache/solr/pull/1013
**On 9.x,** Solrj-Zookeeper should be "opt-out", thus a user needs to opt-out if they don't want it. Don't change main (opt-in).
I looked at the upgrade docs for 9.1 in `solr-upgrade-notes.adoc` and I thought maybe just leave it be. What it says isn't wrong -- yes you will need this JAR if you use this functionality. It's unspecified wether this happens automatically or not based on Maven POM (for those that use it which is most folks for sure). In some sense it's a detail.
In main, I can add a note for the 10.x upgrade to mention this, where it's more impactful / noticeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #1013: SOLR-15342 Solrj-Zookeeper: opt-out on 9x
Posted by GitBox <gi...@apache.org>.
dsmiley merged PR #1013:
URL: https://github.com/apache/solr/pull/1013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1013: SOLR-15342 Solrj-Zookeeper: opt-out on 9x
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1013:
URL: https://github.com/apache/solr/pull/1013#issuecomment-1248188733
BTW I spot-checked the generated POM to observe the desired runtime dependency.
> A CHANGES line is probably nice though, perhaps co-located with the original changes line?
I disagree. This particular PR effectively augments the existing work that already has a CHANGES.txt. It's a branch specific implementation detail. Instead, I think maybe main should not only have an upgrade note but possible a mention of this difference in CHANGES.txt in its own section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1013: SOLR-15342 Solrj-Zookeeper: opt-out on 9x
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1013:
URL: https://github.com/apache/solr/pull/1013#issuecomment-1248292663
I just realized this PR is on the same JIRA number as the main task, and it does not say that users need to do anything differently, so then I agree too. It will be in 10.0 that we need to document the opt-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org