You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "jinggou (via GitHub)" <gi...@apache.org> on 2026/07/23 19:45:36 UTC
[PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
jinggou opened a new pull request, #14:
URL: https://github.com/apache/phoenix-adapters/pull/14
…rting REST server
Before starting the REST server in integration tests, ensure Phoenix system tables
are fully initialized by calling TestUtils.awaitPhoenixReady().
This eliminates the race condition that caused intermittent test failures with:
org.apache.phoenix.exception.PhoenixIOException: SYSTEM.CATALOG
Caused by: org.apache.hadoop.hbase.TableNotFoundException: SYSTEM.CATALOG
The fix adds TestUtils.awaitPhoenixReady(url) calls to all 82 integration test classes, either directly in their @BeforeClass methods or through inheritance from base classes like BaseSegmentScanIT, KclTestBase, UpdateItemBaseTests, and SegmentScanIT.
The awaitPhoenixReady() method polls for up to 30 seconds (vs RESTServer's 5 seconds) for Phoenix to become ready, providing sufficient time for SYSTEM.CATALOG initialization even on slow CI workers.
Changes:
- Added TestUtils.awaitPhoenixReady() calls to 58 integration test classes
- Fixed DeleteTableIT to construct Phoenix JDBC URL before REST server initialization
- 24 additional test classes inherit the fix through base class inheritance
- Total coverage: 82/82 integration test classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3648919113
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/ConnectionConfigIT.java:
##########
@@ -62,6 +62,8 @@ public static void initialize() throws Exception {
utility.startMiniCluster();
String zkQuorum = "127.0.0.1:" + utility.getZkCluster().getClientPort();
url = PhoenixRuntime.JDBC_PROTOCOL + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum;
+ TestUtils.awaitPhoenixReady(url);
+
Review Comment:
We have 2 options:
1. remove `awaitPhoenixReady()` from this test
2. remove this test entirely
I prefer option 1, which means this single IT test will not be protected by `awaitPhoenixReady()` and can lead to flaky test failure, which is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
Posted by "jinggou (via GitHub)" <gi...@apache.org>.
jinggou commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3662801640
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/QueryIndexExclusiveStartKeyIT.java:
##########
@@ -99,7 +100,11 @@ public static void setup() throws Exception {
utility = new HBaseTestingUtility(conf);
setUpConfigForMiniCluster(conf);
utility.startMiniCluster();
+ String zkQuorum = "127.0.0.1:" + utility.getZkCluster().getClientPort();
Review Comment:
updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
Posted by "palashc (via GitHub)" <gi...@apache.org>.
palashc commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3661492625
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/ConnectionConfigIT.java:
##########
@@ -62,6 +62,8 @@ public static void initialize() throws Exception {
utility.startMiniCluster();
String zkQuorum = "127.0.0.1:" + utility.getZkCluster().getClientPort();
url = PhoenixRuntime.JDBC_PROTOCOL + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum;
+ TestUtils.awaitPhoenixReady(url);
+
Review Comment:
makes sense, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
Posted by "palashc (via GitHub)" <gi...@apache.org>.
palashc commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3641274516
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/GetRecordsMultipleProducersIT.java:
##########
@@ -134,6 +134,9 @@ public static void initialize() throws Exception {
restServer = new RESTServer(utility.getConfiguration());
restServer.run();
+ String url = "http://" + restServer.getServerAddress();
Review Comment:
We need to build a JDBC URL from the ZK quorum here, not the rest server url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3670878872
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/ConnectionConfigIT.java:
##########
@@ -60,8 +60,9 @@ public static void initialize() throws Exception {
utility = new HBaseTestingUtility(conf);
setUpConfigForMiniCluster(conf);
utility.startMiniCluster();
- String zkQuorum = "127.0.0.1:" + utility.getZkCluster().getClientPort();
+ String zkQuorum = "localhost:" + utility.getZkCluster().getClientPort();
Review Comment:
Here we should let it be 127.0.0.1 otherwise we have test failure in the latest build?
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/ConnectionConfigIT.java:
##########
@@ -60,8 +60,9 @@ public static void initialize() throws Exception {
utility = new HBaseTestingUtility(conf);
setUpConfigForMiniCluster(conf);
utility.startMiniCluster();
- String zkQuorum = "127.0.0.1:" + utility.getZkCluster().getClientPort();
+ String zkQuorum = "localhost:" + utility.getZkCluster().getClientPort();
Review Comment:
Basically no change needed in this IT test :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7964: Wait for Phoenix system tables to initialize before sta… [phoenix-adapters]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3661613234
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/QueryIndexExclusiveStartKeyIT.java:
##########
@@ -99,7 +100,11 @@ public static void setup() throws Exception {
utility = new HBaseTestingUtility(conf);
setUpConfigForMiniCluster(conf);
utility.startMiniCluster();
+ String zkQuorum = "127.0.0.1:" + utility.getZkCluster().getClientPort();
Review Comment:
Why we have 127.0.0.1 here instead of localhost (everywhere else)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org