[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #161: feat: support to mount 3rd plugins from configmap

[GitBox <gi...@apache.org>]

gxthrj commented on a change in pull request #161:
URL: https://github.com/apache/apisix-helm-chart/pull/161#discussion_r737068756



##########
File path: charts/apisix/templates/deployment.yaml
##########
@@ -94,6 +103,13 @@ spec:
         - configMap:
             name: {{ include "apisix.fullname" . }}
           name: apisix-config
+      {{- if .Values.customPlugins.enabled }}
+      {{- range $plugin := .Values.customPlugins.plugins }}
+        - name: plugin-{{ $plugin.configMap.name }}
+          configMap:
+            name: {{ $plugin.configMap.name }}

Review comment:
       If the `configMap` does not exist,  APISIX will be shut down.
   
   How about unifying the custom plug-in configuration to `charts/apisix/templates/configmap.yaml`, distinguished with different field names.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org