You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/04/21 00:38:56 UTC
[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2269
[ZEPPELIN-2434] Credential feature does work in JDBC interpreter
### What is this PR for?
Credential feature does not work in JDBC interpreter.
This PR fixes unittest that does not detect this bug and fix jdbc interpreter to correctly read credential.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Fix unittest
* [x] - Fix condition when use credential, when use property.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2434
### How should this be tested?
Set empty `default.user` property and set id/pw in 'credential' menu. And try use jdbc interpreter.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin jdbc_credential
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2269
----
commit 1de7ea62fec40a503272db5737af47fa284fb0e2
Author: Lee moon soo <mo...@apache.org>
Date: 2017-04-21T00:31:44Z
Use crednetial information instead of property when user is empty string.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2269: [ZEPPELIN-2434] Credential feature does work in JDBC i...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2269
Merge to master and branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...
Posted by Leemoonsoo <gi...@git.apache.org>.
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2269
[ZEPPELIN-2434] Credential feature does work in JDBC interpreter
### What is this PR for?
Credential feature does not work in JDBC interpreter.
This PR fixes unittest that does not detect this bug and fix jdbc interpreter to correctly read credential.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Fix unittest
* [x] - Fix condition when use credential, when use property.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2434
### How should this be tested?
Set empty `default.user` property and set id/pw in 'credential' menu. And try use jdbc interpreter.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin jdbc_credential
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2269
----
commit 1de7ea62fec40a503272db5737af47fa284fb0e2
Author: Lee moon soo <mo...@apache.org>
Date: 2017-04-21T00:31:44Z
Use crednetial information instead of property when user is empty string.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---