You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by merlimat <gi...@git.apache.org> on 2017/05/10 00:38:49 UTC
[GitHub] bookkeeper pull request #144: BOOKKEEPER-1054: Add gitignore file
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/144
BOOKKEEPER-1054: Add gitignore file
We should have a .gitignore file to hide all build generated files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper git-ignore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #144
----
commit eb841272aedac0b7426e96102d92a2d577daff3c
Author: Matteo Merli <mm...@apache.org>
Date: 2017-05-10T00:35:34Z
BOOKKEEPER-1054: Add gitignore file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #144: BOOKKEEPER-1054: Add gitignore file
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/144
@merlimat could you also include NetBeans files:
`/**/nb-configuration.xml`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #144: BOOKKEEPER-1054: Add gitignore file
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #144: BOOKKEEPER-1054: Add gitignore file
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/144
@merlimat I have some trouble in checking out this commit
```
git fetch apache-github pull/114/head:bookeeper-1054-gitignore
git checkout bookeeper-1054-gitignore
```
the .gitignore file is not checked out !
`git status`
> Sul branch bookeeper-1054-gitignore
> nothing to commit, working directory clean
`git log`
> commit d8a7ac310947049f65687e33d92b847c44c91a39
> Author: Matteo Merli <mm...@apache.org>
> Date: Tue May 9 18:17:19 2017 -0700
BOOKKEEPER-1053: Upgrade RAT maven version to 0.12 and ignore Eclipse project files
it seems that your commit eb841272aedac0b7426e96102d92a2d577daff3c is not getting applied
any hint ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #144: BOOKKEEPER-1054: Add gitignore file
Posted by merlimat <gi...@git.apache.org>.
Github user merlimat commented on the issue:
https://github.com/apache/bookkeeper/pull/144
@eolivelli the pr # is 144 and not 114 as in your snippet above. I will also add the netbeans files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---