[GitHub] [cordova-android] breautek commented on pull request #1384: fix: escape strings.xml app name

[GitBox <gi...@apache.org>]

breautek commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005768452


   > We have been removing lodash from our dependencies because of the vuln. report frequencies.
   > 
   > I have discussed with others on dropping `@netflix/nerror` because they neglected to update their package over 2 years now and even with PRs open to resolve some issues.
   > 
   > [Netflix/nerror#18](https://github.com/Netflix/nerror/pull/18)
   
   To add onto this, we can probably solve the same issue using the JS native method [encodeURIComponent](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent) so that we can avoid introducing another lodash dependency. I'm pretty sure the method exists in NodeJS environments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org