You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/29 03:19:42 UTC
[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #20880: fix: Save dataset + chart when Chart source is Query
lyndsiWilliams commented on code in PR #20880:
URL: https://github.com/apache/superset/pull/20880#discussion_r932833324
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -55,14 +59,22 @@ type SaveModalState = {
saveToDashboardId: number | string | null;
newSliceName?: string;
newDashboardName?: string;
+ datasetName: string;
alert: string | null;
action: ActionType;
+ isLoading: boolean;
+ saveStatus: string | null;
};
export const StyledModal = styled(Modal)`
.ant-modal-body {
overflow: visible;
}
+ i {
+ position: absolute;
+ top: -21px;
+ left: 107px;
Review Comment:
```suggestion
top: -${({ theme }) => theme.gridUnit * 5.25}px;
left: ${({ theme }) => theme.gridUnit * 26.75}px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org