[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2196: SOLR-15071: Fix ArrayIndexOutOfBoundsException in contrib/ltr SolrFeatureScorer

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #2196:
URL: https://github.com/apache/lucene-solr/pull/2196#discussion_r556883061



##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/Feature.java
##########
@@ -365,11 +364,6 @@ public DocIdSetIterator iterator() {
         return in.iterator();
       }
 
-      @Override

Review comment:
       @cpoerschke  Let's add a comment saying that we intentionally don't delegate twoPhaseIterator because it doesn't work, and that we don't know why, with a reference to the JIRA issue?
   Other than that, let's commit this to protect users as-is.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org