You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kristopherkane (via GitHub)" <gi...@apache.org> on 2023/07/10 19:49:54 UTC

[GitHub] [airflow] kristopherkane opened a new pull request, #32500: Filtering and ordering results of DataprocListBatchesOperator

kristopherkane opened a new pull request, #32500:
URL: https://github.com/apache/airflow/pull/32500

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   
   closes: #32499
   
   This adds filtering to Google Cloud DataprocListBatchesOperator where as current behavior is to return every job ever run inside a GCP project.  
   
   This capability is enabled by the recent version upgrades of the Google Cloud provider. 
   
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] hussein-awala commented on a diff in pull request #32500: Filtering and ordering results of DataprocListBatchesOperator

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #32500:
URL: https://github.com/apache/airflow/pull/32500#discussion_r1258918530


##########
tests/providers/google/cloud/hooks/test_dataproc.py:
##########
@@ -939,6 +941,8 @@ async def test_list_batches(self, mock_client):
                 parent=PARENT.format(GCP_PROJECT, GCP_LOCATION),
                 page_size=None,
                 page_token=None,
+                filter_=None,
+                order_by=None,

Review Comment:
   ```suggestion
                   filter=None,
                   order_by=None,
   ```



##########
tests/providers/google/cloud/hooks/test_dataproc.py:
##########
@@ -491,6 +491,8 @@ def test_list_batches(self, mock_client):
                 parent=PARENT.format(GCP_PROJECT, GCP_LOCATION),
                 page_size=None,
                 page_token=None,
+                filter_=None,
+                order_by=None,

Review Comment:
   ```suggestion
                   filter=None,
                   order_by=None,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kristopherkane commented on pull request #32500: Filtering and ordering results of DataprocListBatchesOperator

Posted by "kristopherkane (via GitHub)" <gi...@apache.org>.
kristopherkane commented on PR #32500:
URL: https://github.com/apache/airflow/pull/32500#issuecomment-1629631729

   To note, filtering and ordering are optional arguments and default behavior of the operator are unchanged.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #32500: Filtering and ordering results of DataprocListBatchesOperator

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32500:
URL: https://github.com/apache/airflow/pull/32500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org