[GitHub] [phoenix] jpisaac commented on a diff in pull request #1598: PHOENIX-6907 Explain Plan should output region locations with servers

["jpisaac (via GitHub)" <gi...@apache.org>]

jpisaac commented on code in PR #1598:
URL: https://github.com/apache/phoenix/pull/1598#discussion_r1185634513


##########
phoenix-core/src/main/antlr3/PhoenixSQL.g:
##########
@@ -452,7 +454,14 @@ oneStatement returns [BindableStatement ret]
 finally{ contextStack.pop(); }
     
 explain_node returns [BindableStatement ret]
-    :   EXPLAIN q=oneStatement {$ret=factory.explain(q);}
+    :   EXPLAIN (w=WITH)? (r=REGIONS)? q=oneStatement

Review Comment:
   Would it make sense to not change what the EXPLAIN statement generates. But have all plan info/attributes generated all the time.
   
   And have different kinds of plan output generators. 
   We may want to look at how other DBs have implemented it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org