You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/06/02 10:09:37 UTC

[GitHub] [mesos] asekretenko edited a comment on pull request #386: Fixed a LevelDBStorage bug where positions would overflow.

asekretenko edited a comment on pull request #386:
URL: https://github.com/apache/mesos/pull/386#issuecomment-852899178


   P.S. Looks like those who implemented backward-incompatible fixes in their private forks will either need one more backward-incompatible upgrade with clearing the log, or to patch out this fix. Given that the tests in this PR should work with alternative approaches to fixing `encode()` as well, this should not be a big deal in either case.
   
   It might even be the case that upgrading from a straightforward 20-digit encoding to the encoding introduced by this patch is _functionally_ equivalent to simply dropping the log on a master: all the previously recorded 20-digit keys will become unreachable after an upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org