You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/26 09:20:35 UTC
[GitHub] [tvm] sisleyli opened a new pull request, #13490: [Relay][Pattern] Enable rewrite_once in class:DFPatternRewrite
sisleyli opened a new pull request, #13490:
URL: https://github.com/apache/tvm/pull/13490
In the original `DFPatternRewrite` class, the default is to rewrite multiple times, I think it is necessary for the user to set whether to run the callback once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #13490: [Relay][Pattern] Enable rewrite_once in class:DFPatternRewrite
Posted by GitBox <gi...@apache.org>.
masahi merged PR #13490:
URL: https://github.com/apache/tvm/pull/13490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sisleyli commented on pull request #13490: [Relay][Pattern] Enable rewrite_once in class:DFPatternRewrite
Posted by GitBox <gi...@apache.org>.
sisleyli commented on PR #13490:
URL: https://github.com/apache/tvm/pull/13490#issuecomment-1328605797
> How would a user initialize this variable if he / she wants to set it to true?
In general, the user inherits the class and assigns a value to the pattern_ in the constructor(we can see the code in `src/relay/transforms/simplify_expr.cc`), so I think it is enough to set true for this variable at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #13490: [Relay][Pattern] Enable rewrite_once in class:DFPatternRewrite
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13490:
URL: https://github.com/apache/tvm/pull/13490#issuecomment-1328602594
How would a user initialize this variable if he / she wants to set it to true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sisleyli commented on pull request #13490: [Relay][Pattern] Enable rewrite_once in class:DFPatternRewrite
Posted by GitBox <gi...@apache.org>.
sisleyli commented on PR #13490:
URL: https://github.com/apache/tvm/pull/13490#issuecomment-1328018161
Just a small change, but I think it is useful:
```cpp
DFPatternRewriteComposer composer;
composer.AddRewrite<Once>();
composer.AddRewrite<Once>();
composer.AddRewrite<Multiple>();
return RewritePatterns(composer.MakeCallbacks(), expr, mod);
```
What do you think? cc @masahi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13490: [Relay][Pattern] Enable rewrite_once in class:DFPatternRewrite
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13490:
URL: https://github.com/apache/tvm/pull/13490#issuecomment-1328012471
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `relay`, `pattern` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org