Re: [PR] NIFI-14191 Added the previous process group to the URL [nifi]

["mosermw (via GitHub)" <gi...@apache.org>]

mosermw commented on PR #9849:
URL: https://github.com/apache/nifi/pull/9849#issuecomment-3246696697

   This feels like a really useful feature to me.  I tested it and I like how it works.
   
   To test @mcgilman's concern, I grabbed a deep link to a processor that was two groups down.  Then I cleared my browser cache and cookies and restarted the browser.  When I navigated to the deep link, the processor was selected and the viewport was centered in the PG.  Leave Group twice also centered those viewports.  I moved the viewport on the way back down to the original processor, and on the way back out the shifted viewports were restored properly.
   
   Even though I don't understand the intricacies of the Typescript code in this PR, it appears simple enough that it can be merged with thorough testing.  So if this PR expires, I'm inclined to re-open and merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org