[GitHub] [arrow-datafusion] novemberkilo edited a comment on pull request #922: WIP Optimize hash_aggregate when there are no null group keys

[GitBox <gi...@apache.org>]

novemberkilo edited a comment on pull request #922:
URL: https://github.com/apache/arrow-datafusion/pull/922#issuecomment-913096913


   Hi @alamb - I've used `datafusion_aggregate_bench` to run up a comparison with `master` and the ratios are coming up at 0.99 so there's nothing significant in the way of a performance improvement yet.  
   
   Could you please help me understand your suggestion:
   
   > am not sure how well the compiler will be able to optimize given a has nulls parameter has_nulls -- it might need to be hoisted out of this loop (the call to all here)
   
   I'm not sure what this means. Are you perhaps suggesting that I use an index lookup of `null_information` rather than using `zip`? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org