You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "llogiq (via GitHub)" <gi...@apache.org> on 2026/06/21 14:07:09 UTC
[PR] chore(global): remove `once_cell` in favor of the standard library [iggy]
llogiq opened a new pull request, #3524:
URL: https://github.com/apache/iggy/pull/3524
## Which issue does this PR address?
None, it's just one step to remove the `once_cell` crate from the build path.
## Rationale
Once the other dependencies using it have been updated to use the standard library types instead, the build will require one crate less.
## What changed?
This just wholesale removes the `once_cell` crate from all iggy crate's dependencies, replacing all uses with the respective standard library types.
## Local Execution
- Passed
- Pre-commit hooks ran
## AI Usage
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove `once_cell` in favor of the standard library [iggy]
Posted by "llogiq (via GitHub)" <gi...@apache.org>.
llogiq commented on PR #3524:
URL: https://github.com/apache/iggy/pull/3524#issuecomment-4770274075
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove `once_cell` in favor of the standard library [iggy]
Posted by "llogiq (via GitHub)" <gi...@apache.org>.
llogiq commented on PR #3524:
URL: https://github.com/apache/iggy/pull/3524#issuecomment-4779240231
I had missed one place in the tests when adding files to the commit. Sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove `once_cell` in favor of the standard library [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #3524:
URL: https://github.com/apache/iggy/pull/3524#issuecomment-4773593203
looks like CI is failing @llogiq
https://github.com/apache/iggy/actions/runs/27945887687/job/82696624385?pr=3524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(global): remove `once_cell` in favor of the standard library [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3524:
URL: https://github.com/apache/iggy/pull/3524#issuecomment-4762382905
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3524?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.49%. Comparing base ([`4a48008`](https://app.codecov.io/gh/apache/iggy/commit/4a48008eb320bc5c0576aea92371788d76965e8b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06f0942`](https://app.codecov.io/gh/apache/iggy/commit/06f09426c7cfc9a21035b443abd7c7d6f3a5461d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3524 +/- ##
============================================
- Coverage 74.27% 73.49% -0.78%
Complexity 937 937
============================================
Files 1259 1196 -63
Lines 125969 121282 -4687
Branches 101644 101555 -89
============================================
- Hits 93558 89131 -4427
+ Misses 29396 29135 -261
- Partials 3015 3016 +1
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.16% <ø> (ø)` | |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.57% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.10% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.88% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.29% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.27% <ø> (-3.95%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.36% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3524?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/connectors/runtime/src/source.rs](https://app.codecov.io/gh/apache/iggy/pull/3524?src=pr&el=tree&filepath=core%2Fconnectors%2Fruntime%2Fsrc%2Fsource.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3J1bnRpbWUvc3JjL3NvdXJjZS5ycw==) | `80.11% <ø> (ø)` | |
| [core/connectors/sdk/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/3524?src=pr&el=tree&filepath=core%2Fconnectors%2Fsdk%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3Nkay9zcmMvbGliLnJz) | `56.17% <ø> (ø)` | |
| [core/connectors/sdk/src/sink.rs](https://app.codecov.io/gh/apache/iggy/pull/3524?src=pr&el=tree&filepath=core%2Fconnectors%2Fsdk%2Fsrc%2Fsink.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3Nkay9zcmMvc2luay5ycw==) | `75.59% <ø> (ø)` | |
| [core/connectors/sdk/src/source.rs](https://app.codecov.io/gh/apache/iggy/pull/3524?src=pr&el=tree&filepath=core%2Fconnectors%2Fsdk%2Fsrc%2Fsource.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3Nkay9zcmMvc291cmNlLnJz) | `80.27% <ø> (ø)` | |
| [core/server\_common/src/memory\_pool.rs](https://app.codecov.io/gh/apache/iggy/pull/3524?src=pr&el=tree&filepath=core%2Fserver_common%2Fsrc%2Fmemory_pool.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXJfY29tbW9uL3NyYy9tZW1vcnlfcG9vbC5ycw==) | `70.00% <ø> (ø)` | |
... and [81 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3524/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove `once_cell` in favor of the standard library [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #3524:
URL: https://github.com/apache/iggy/pull/3524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove `once_cell` in favor of the standard library [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski commented on PR #3524:
URL: https://github.com/apache/iggy/pull/3524#issuecomment-4796961126
@llogiq Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(global): remove `once_cell` in favor of the standard library [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3524:
URL: https://github.com/apache/iggy/pull/3524#issuecomment-4762226910
<!-- iggy-pr-triage-welcome -->
Thanks for the PR. It is labeled `S-waiting-on-review` and queued for review.
Slash commands (own line, regular comment) move it around the queue:
- `/ready` - back to `S-waiting-on-review` after addressing feedback
- `/author` - flip to `S-waiting-on-author` while you finish changes
- `/request-review @user-or-team` - request a reviewer
See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md#pr-triage-commands) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove `once_cell` in favor of the standard library [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex commented on PR #3524:
URL: https://github.com/apache/iggy/pull/3524#issuecomment-4767293860
Looks like conventional commits do not allow `global` as valid parameter. I've renamed the PR title and dropped it from the scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org