You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/05/21 16:44:12 UTC
[GitHub] nifi-minifi-cpp pull request #334: Minificpp 502
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334
Minificpp 502
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-502
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
----
commit c67473f5e15068629eab46cb9fdcc48df6f56d30
Author: Andrew I. Christianson <an...@...>
Date: 2018-05-21T15:55:14Z
MINIFICPP-501 Incorporate dependent property metadata into agent information
commit 1d8864f004d9609d88f9b32b474f7b0b96f582d0
Author: Andrew I. Christianson <an...@...>
Date: 2018-05-21T16:43:40Z
MINIFICPP-502 Add validation to config parser to validate required properties
----
---
[GitHub] nifi-minifi-cpp pull request #334: MINIFICPP-502 Add validation to config pa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/334
---
[GitHub] nifi-minifi-cpp issue #334: MINIFICPP-502 Add validation to config parser to...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/334
Fixed the linter issue.
---
[GitHub] nifi-minifi-cpp pull request #334: MINIFICPP-502 Add validation to config pa...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189913737
--- Diff: libminifi/include/core/Property.h ---
@@ -56,10 +56,15 @@ class Property {
/*!
* Create a new property
*/
- Property(const std::string name, const std::string description, const std::string value, bool is_required)
--- End diff --
Yeah MINIFICPP-502 is to perform validation. MINIFICPP-501 is for incorporating the validation metadata into the agent info.
---
[GitHub] nifi-minifi-cpp pull request #334: MINIFICPP-502 Add validation to config pa...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189748104
--- Diff: libminifi/include/core/Property.h ---
@@ -56,10 +56,15 @@ class Property {
/*!
* Create a new property
*/
- Property(const std::string name, const std::string description, const std::string value, bool is_required)
--- End diff --
What's the purpose of this ticket? is_required already existed...
---
[GitHub] nifi-minifi-cpp pull request #334: MINIFICPP-502 Add validation to config pa...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189747932
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -666,10 +669,10 @@ void YamlConfiguration::parsePortYaml(YAML::Node *portNode,
checkRequiredField(&inputPortsObj, "id",
CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY,
"The field 'id' is required for "
- "the port named '" + nameStr + "' in the YAML Config. If this port "
--- End diff --
There are linter failures. We have a formatter that can be used with intellij with a little work. May help avoid some of these issues. You're making changes that override our formatter. Would probably behoove us to apply formatters as a pre commit hook.
---
[GitHub] nifi-minifi-cpp issue #334: MINIFICPP-502 Add validation to config parser to...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/334
501 is a subset of 502. Is that correct? If so I'll review 502. The same comments apply here
---