You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by hu...@apache.org on 2023/05/07 05:32:34 UTC

[plc4x] 03/03: feat(plc4py): Formatting and more dummy methods

This is an automated email from the ASF dual-hosted git repository.

hutcheb pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git

commit 2db561306ee49f2ee17363dd7db5306e0e0c4595
Author: Ben Hutcheson <be...@gmail.com>
AuthorDate: Sun May 7 07:10:07 2023 +0200

    feat(plc4py): Formatting and more dummy methods
---
 sandbox/plc4py/plc4py/spi/generation/WriteBuffer.py | 3 +--
 sandbox/plc4py/plc4py/spi/values/common.py          | 5 ++++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/sandbox/plc4py/plc4py/spi/generation/WriteBuffer.py b/sandbox/plc4py/plc4py/spi/generation/WriteBuffer.py
index f58c25d2dd..63d4d5969c 100644
--- a/sandbox/plc4py/plc4py/spi/generation/WriteBuffer.py
+++ b/sandbox/plc4py/plc4py/spi/generation/WriteBuffer.py
@@ -46,7 +46,7 @@ class WriteBuffer(ByteOrderAware, PositionAware):
         raise NotImplementedError
 
     def write_byte(self, value: c_byte, logical_name: str = "", **kwargs) -> None:
-        self.write_signed_byte(value, logical_name, kwargs)
+        self.write_signed_byte(value, logical_name, **kwargs)
 
     def write_byte_array(self, value: List[c_byte], logical_name: str = "", **kwargs) -> None:
         raise NotImplementedError
@@ -87,7 +87,6 @@ class WriteBuffer(ByteOrderAware, PositionAware):
     def write_virtual(self, value: str, logical_name: str = "", **kwargs) -> None:
         raise NotImplementedError
 
-
     #
     # This method can be used to influence serializing (e.g. intercept whole types and render them in a simplified form)
     #
diff --git a/sandbox/plc4py/plc4py/spi/values/common.py b/sandbox/plc4py/plc4py/spi/values/common.py
index 2c76fbc8b8..c5ca06e1a6 100644
--- a/sandbox/plc4py/plc4py/spi/values/common.py
+++ b/sandbox/plc4py/plc4py/spi/values/common.py
@@ -14,7 +14,10 @@
 #  KIND, either express or implied.  See the License for the
 #  specific language governing permissions and limitations
 #  under the License.
+from plc4py.spi.generation.WriteBuffer import WriteBuffer
 
 
 class Serializable:
-    pass
+
+    def serialize(self, write_buffer: WriteBuffer):
+        pass