You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Abrasha <gi...@git.apache.org> on 2017/11/04 10:07:55 UTC
[GitHub] commons-text pull request #75: Minor refactorings
GitHub user Abrasha opened a pull request:
https://github.com/apache/commons-text/pull/75
Minor refactorings
- remove unnecessary (un)boxing
- replace `for: add` with bulk add `Collections.addAll`
- replace iterator with `for each` where possible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Abrasha/commons-text fix/remove-unnecessary-(un)boxing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-text/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit bcb78636bbcc7f5591e3512e49bf58b354850b0c
Author: abrasha <aa...@gmail.com>
Date: 2017-11-04T10:06:50Z
- remove unnecessary (un)boxing
- replace `for: add` with bulk add `Collections.addAll`
- replace iterator with `for each` where possible
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #75: Minor refactorings
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/75
Thanks! 👍
It would be nice if you could fix the check-style violations, see: https://travis-ci.org/apache/commons-text/jobs/297158450
Run `mvn checkstyle:check` (or just `mvn`) to replicated it locally.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #75: Minor refactorings
Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on the issue:
https://github.com/apache/commons-text/pull/75
@PascalSchumacher done. Force pushed this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #75: Minor refactorings
Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on the issue:
https://github.com/apache/commons-text/pull/75
Sure. Will be done in an hour)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text pull request #75: Minor refactorings
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/75
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #75: Minor refactorings
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/75
[](https://coveralls.io/builds/14037992)
Coverage decreased (-0.003%) to 98.295% when pulling **58f0f3e6a7f730eb6cb7bc77cabbbaf54ae48353 on Abrasha:fix/remove-unnecessary-(un)boxing** into **6313d401d1631884b6a4ae31f2714b066b62f629 on apache:master**.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org