[jira] [Commented] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831320#comment-13831320 ] 

Hadoop QA commented on HBASE-8758:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12615552/HBASE-8758-r1545168.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation patch that doesn't require tests.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestRestartCluster

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7983//console

This message is automatically generated.

> Error in RegionCoprocessorHost class preScanner method documentation.
> ---------------------------------------------------------------------
>
>                 Key: HBASE-8758
>                 URL: https://issues.apache.org/jira/browse/HBASE-8758
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, documentation
>    Affects Versions: 0.98.0, 0.95.2, 0.94.9
>         Environment: Any. Actually it is just wrong comment in code.
>            Reporter: Roman Nikitchenko
>            Priority: Trivial
>              Labels: comments, coprocessors, documentation
>         Attachments: HBASE-8758-r1545168.patch
>
>
> preScannerOpen() method of RegionCoprocessorHost class is documented to return 'false' value in negative case (default operation should not be bypassed). Actual implementation returns 'null' value.
> Proposed solution is just to correct comment to match existing implementation.



--
This message was sent by Atlassian JIRA
(v6.1#6144)