You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/10/27 12:40:46 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request, #4273: ARTEMIS-4076: add JDK 19 run to CI jobs
gemmellr opened a new pull request, #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273
Fixes a couple of issues causing test failures or hangs, and adds a Java 19 job to the CI runs on push/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4273: ARTEMIS-4076: add JDK 19 run to CI jobs
Posted by GitBox <gi...@apache.org>.
gemmellr commented on code in PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273#discussion_r1007003158
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -244,7 +244,7 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("Attach Listener")) {
return true;
- } else if ((javaVendor.contains("IBM") || isSystemThread) && threadName.equals("process reaper")) {
+ } else if ((javaVendor.contains("IBM") || isSystemThread) && (threadName.equals("process reaper") || threadName.startsWith("process reaper (pid"))) {
Review Comment:
But yes we could use 'starts with' for both if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4273: ARTEMIS-4076: add JDK 19 run to CI jobs
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on code in PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273#discussion_r1006904121
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -244,7 +244,7 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("Attach Listener")) {
return true;
- } else if ((javaVendor.contains("IBM") || isSystemThread) && threadName.equals("process reaper")) {
+ } else if ((javaVendor.contains("IBM") || isSystemThread) && (threadName.equals("process reaper") || threadName.startsWith("process reaper (pid"))) {
Review Comment:
did you mean the (pid) in the string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #4273: ARTEMIS-4076: add JDK 19 run to CI jobs
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4273: ARTEMIS-4076: add JDK 19 run to CI jobs
Posted by GitBox <gi...@apache.org>.
gemmellr commented on code in PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273#discussion_r1007001674
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -244,7 +244,7 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("Attach Listener")) {
return true;
- } else if ((javaVendor.contains("IBM") || isSystemThread) && threadName.equals("process reaper")) {
+ } else if ((javaVendor.contains("IBM") || isSystemThread) && (threadName.equals("process reaper") || threadName.startsWith("process reaper (pid"))) {
Review Comment:
It isnt always in the name, it comes and goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4273: ARTEMIS-4076: add JDK 19 run to CI jobs
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on code in PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273#discussion_r1006906199
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -244,7 +244,7 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("Attach Listener")) {
return true;
- } else if ((javaVendor.contains("IBM") || isSystemThread) && threadName.equals("process reaper")) {
+ } else if ((javaVendor.contains("IBM") || isSystemThread) && (threadName.equals("process reaper") || threadName.startsWith("process reaper (pid"))) {
Review Comment:
yes... I think you just do startsWith("process reaper");
As the change on the idk is
process reaper (pid " + pid + ")");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4273: ARTEMIS-4076: add JDK 19 run to CI jobs
Posted by GitBox <gi...@apache.org>.
gemmellr commented on code in PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273#discussion_r1007001674
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -244,7 +244,7 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("Attach Listener")) {
return true;
- } else if ((javaVendor.contains("IBM") || isSystemThread) && threadName.equals("process reaper")) {
+ } else if ((javaVendor.contains("IBM") || isSystemThread) && (threadName.equals("process reaper") || threadName.startsWith("process reaper (pid"))) {
Review Comment:
It isnt always in the name, it comes and goes.
(EDIT: I misread the original question...yes I meant it, I only added the " (pid" suffix without the remainder of the string since I wouldnt know the pid it is actually working for at that point. I had decided not to just do startsWith("process reaper") since it isnt as precise. But it is more concise and unlikely to be an issue so I dont mind, changed.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org