[GitHub] [kafka] showuon commented on a change in pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#discussion_r635100532



##########
File path: README.md
##########
@@ -245,6 +245,7 @@ includes inlining of methods within the scala library (which avoids lambda alloc
 only safe if the Scala library version is the same at compile time and runtime. Since we cannot guarantee this for all cases (for example, users
 may depend on the kafka jar for integration tests where they may include a scala library with a different version), we don't enable it by
 default. See https://www.lightbend.com/blog/scala-inliner-optimizer for more details.
+* `checkstyleVersion`: override CheckStyle dependency version

Review comment:
       question: do you think we should add some note in the above `Checkstyle` section?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org