You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by bs...@apache.org on 2007/09/20 02:03:13 UTC
svn commit: r577480 - /commons/proper/email/trunk/pom.xml
Author: bspeakmon
Date: Wed Sep 19 17:03:12 2007
New Revision: 577480
URL: http://svn.apache.org/viewvc?rev=577480&view=rev
Log:
- use Official Maven 2 Method(tm) of enforcing source/target on compiler
Modified:
commons/proper/email/trunk/pom.xml
Modified: commons/proper/email/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/pom.xml?rev=577480&r1=577479&r2=577480&view=diff
==============================================================================
--- commons/proper/email/trunk/pom.xml (original)
+++ commons/proper/email/trunk/pom.xml Wed Sep 19 17:03:12 2007
@@ -246,11 +246,6 @@
</dependency>
</dependencies>
- <properties>
- <maven.compile.source>1.4</maven.compile.source>
- <maven.compile.target>1.4</maven.compile.target>
- </properties>
-
<build>
<sourceDirectory>src/java</sourceDirectory>
<testSourceDirectory>src/test</testSourceDirectory>
@@ -273,6 +268,14 @@
</testResource>
</testResources>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>1.4</source>
+ <target>1.4</target>
+ </configuration>
+ </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
Re: svn commit: r577480 - /commons/proper/email/trunk/pom.xml
Posted by Ben Speakmon <bs...@apache.org>.
Makes sense to me. I'll revert it.
On 9/19/07, Niall Pemberton <ni...@gmail.com> wrote:
>
> IMO we should keep components consistent on this - and this isn't any
> more "official" than using the properties - in fact its exactly the
> same way, except instead of inherting the plugin config from the
> parent pom its now duplcated in email's pom.
>
> Using properties also has another usage - it also adds custom entries
> to the jar's manifest (X-Compile-Source-JDK and X-Compile-Target-JDK)
> which show the source/target settings that were used to build the
> release/jar. The rationale behind this was that it makes the JDK
> compatibility clear - both when the release is reviewed/voted on - and
> also down the line when no-one can remember.
>
> Lastly, by removing the properties from email's pom its now going to
> pick up the default from the parent pom - which are "1.3" so its going
> to be misleading since email will have been built with a source/target
> JDK of 1.4 but the custom entries in the jar's manifest will indicate
> 1.3.
>
> If with components now using m2 then people don't think the current
> way is a good idea then this should be agreed on and a new parent pom
> released. Until that happens though I think we should stick with the
> mechanism thats in place.
>
> Niall
>
>
> On 9/20/07, bspeakmon@apache.org <bs...@apache.org> wrote:
> > Author: bspeakmon
> > Date: Wed Sep 19 17:03:12 2007
> > New Revision: 577480
> >
> > URL: http://svn.apache.org/viewvc?rev=577480&view=rev
> > Log:
> > - use Official Maven 2 Method(tm) of enforcing source/target on compiler
> >
> > Modified:
> > commons/proper/email/trunk/pom.xml
> >
> > Modified: commons/proper/email/trunk/pom.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/email/trunk/pom.xml?rev=577480&r1=577479&r2=577480&view=diff
> >
> ==============================================================================
> > --- commons/proper/email/trunk/pom.xml (original)
> > +++ commons/proper/email/trunk/pom.xml Wed Sep 19 17:03:12 2007
> > @@ -246,11 +246,6 @@
> > </dependency>
> > </dependencies>
> >
> > - <properties>
> > - <maven.compile.source>1.4</maven.compile.source>
> > - <maven.compile.target>1.4</maven.compile.target>
> > - </properties>
> > -
> > <build>
> > <sourceDirectory>src/java</sourceDirectory>
> > <testSourceDirectory>src/test</testSourceDirectory>
> > @@ -273,6 +268,14 @@
> > </testResource>
> > </testResources>
> > <plugins>
> > + <plugin>
> > + <groupId>org.apache.maven.plugins</groupId>
> > + <artifactId>maven-compiler-plugin</artifactId>
> > + <configuration>
> > + <source>1.4</source>
> > + <target>1.4</target>
> > + </configuration>
> > + </plugin>
> > <plugin>
> > <groupId>org.apache.maven.plugins</groupId>
> > <artifactId>maven-surefire-plugin</artifactId>
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r577480 - /commons/proper/email/trunk/pom.xml
Posted by Niall Pemberton <ni...@gmail.com>.
IMO we should keep components consistent on this - and this isn't any
more "official" than using the properties - in fact its exactly the
same way, except instead of inherting the plugin config from the
parent pom its now duplcated in email's pom.
Using properties also has another usage - it also adds custom entries
to the jar's manifest (X-Compile-Source-JDK and X-Compile-Target-JDK)
which show the source/target settings that were used to build the
release/jar. The rationale behind this was that it makes the JDK
compatibility clear - both when the release is reviewed/voted on - and
also down the line when no-one can remember.
Lastly, by removing the properties from email's pom its now going to
pick up the default from the parent pom - which are "1.3" so its going
to be misleading since email will have been built with a source/target
JDK of 1.4 but the custom entries in the jar's manifest will indicate
1.3.
If with components now using m2 then people don't think the current
way is a good idea then this should be agreed on and a new parent pom
released. Until that happens though I think we should stick with the
mechanism thats in place.
Niall
On 9/20/07, bspeakmon@apache.org <bs...@apache.org> wrote:
> Author: bspeakmon
> Date: Wed Sep 19 17:03:12 2007
> New Revision: 577480
>
> URL: http://svn.apache.org/viewvc?rev=577480&view=rev
> Log:
> - use Official Maven 2 Method(tm) of enforcing source/target on compiler
>
> Modified:
> commons/proper/email/trunk/pom.xml
>
> Modified: commons/proper/email/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/pom.xml?rev=577480&r1=577479&r2=577480&view=diff
> ==============================================================================
> --- commons/proper/email/trunk/pom.xml (original)
> +++ commons/proper/email/trunk/pom.xml Wed Sep 19 17:03:12 2007
> @@ -246,11 +246,6 @@
> </dependency>
> </dependencies>
>
> - <properties>
> - <maven.compile.source>1.4</maven.compile.source>
> - <maven.compile.target>1.4</maven.compile.target>
> - </properties>
> -
> <build>
> <sourceDirectory>src/java</sourceDirectory>
> <testSourceDirectory>src/test</testSourceDirectory>
> @@ -273,6 +268,14 @@
> </testResource>
> </testResources>
> <plugins>
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-compiler-plugin</artifactId>
> + <configuration>
> + <source>1.4</source>
> + <target>1.4</target>
> + </configuration>
> + </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org