You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by GitBox <gi...@apache.org> on 2021/03/31 16:53:06 UTC

[GitHub] [pdfbox] valerybokov opened a new pull request #112: split CFFCharset to two classes

valerybokov opened a new pull request #112:
URL: https://github.com/apache/pdfbox/pull/112


   Hi! I found TODO in CFFCharsetCID class and decided to implement it. Hope you find this helpful.
   Several notes:
   - I created CFFCharsetCID and CFFCharsetType1 (new classes) as package private because CFFCharset is abstract.
   Also, I set them as non-abstract because Format0Charset is not abstract. But if you think they should be abstract, I will think about how to change it.
   - I extracted the EmbeddedCharset from CFFParser because it is big class. I don't like to use big inner classes and CFFParser has too many inner classes. But if you want you able to move it (make as inner).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


[GitHub] [pdfbox] lehmi commented on pull request #112: split CFFCharset to two classes

Posted by GitBox <gi...@apache.org>.
lehmi commented on pull request #112:
URL: https://github.com/apache/pdfbox/pull/112#issuecomment-812845677


   I'm going to look into this as well as the others proposed changes in the CFFParser area


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


[GitHub] [pdfbox] THausherr commented on pull request #112: split CFFCharset to two classes

Posted by GitBox <gi...@apache.org>.
THausherr commented on pull request #112:
URL: https://github.com/apache/pdfbox/pull/112#issuecomment-811304883


   Andreas is currently busy with refactoring, so it's better to comment there, so that you don't interfere with each other (this applies also to your recent comment in #107)
   https://issues.apache.org/jira/browse/PDFBOX-5143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


[GitHub] [pdfbox] THausherr edited a comment on pull request #112: split CFFCharset to two classes

Posted by GitBox <gi...@apache.org>.
THausherr edited a comment on pull request #112:
URL: https://github.com/apache/pdfbox/pull/112#issuecomment-811304883


   Andreas is currently busy with refactoring CFF, so it's better to comment there, so that you don't interfere with each other (this applies also to your recent comment in #107)
   https://issues.apache.org/jira/browse/PDFBOX-5143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


[GitHub] [pdfbox] asfgit closed pull request #112: split CFFCharset to two classes

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #112:
URL: https://github.com/apache/pdfbox/pull/112


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org