You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/13 21:27:05 UTC

[GitHub] [maven-archetype] MarianMacik opened a new pull request #92: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

MarianMacik opened a new pull request #92:
URL: https://github.com/apache/maven-archetype/pull/92


   … Maven settings from the main build
   
   [ARCHETYPE-622](https://issues.apache.org/jira/browse/ARCHETYPE-622)
   
   Hi @slachiewicz ,
   
   I have fixed issues with older Maven versions. I didn't know that on internal CI you run much older versions. The tests were too strict and made specifically for newer ones. I have now tested it with Maven versions ranging from 3.2.5 to 3.8.4 and all passed.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-archetype] MarianMacik commented on pull request #92: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.
MarianMacik commented on pull request #92:
URL: https://github.com/apache/maven-archetype/pull/92#issuecomment-992972409


   @slachiewicz One failing build is an unrelated fail which happens also on master, but I am unable to reproduce it. It is a test which was already there and is in no way related to my fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-archetype] slachiewicz commented on pull request #92: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #92:
URL: https://github.com/apache/maven-archetype/pull/92#issuecomment-992991317


   All looks good, thank you for Your time to contribute to our project. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-archetype] slachiewicz closed pull request #92: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #92:
URL: https://github.com/apache/maven-archetype/pull/92


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-archetype] MarianMacik edited a comment on pull request #92: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.
MarianMacik edited a comment on pull request #92:
URL: https://github.com/apache/maven-archetype/pull/92#issuecomment-992972409


   @slachiewicz One failing build is an unrelated fail which happens also on master, but I am unable to reproduce it locally, so probably a GitHub actions thing. It is a test which was already there and is in no way related to my fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org