You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/28 00:01:31 UTC

[GitHub] [geode] Kris-10-0 commented on a change in pull request #7319: GEODE-9833: SPOP Command Support

Kris-10-0 commented on a change in pull request #7319:
URL: https://github.com/apache/geode/pull/7319#discussion_r794098696



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
##########
@@ -300,7 +283,7 @@ private void srandomDuplicateList(int count, List<byte[]> result) {
     }
   }
 
-  private void srandomUniqueListWithSmallCount(int count, List<byte[]> result) {
+  private void srandomUniqueListAddToResult(int count, List<byte[]> result, boolean isSPop) {

Review comment:
       It only adds the index if it isn't spop. When it does spop there is an indexUsed set, but nothing gets added so it is a waste.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org